chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc - Issue 229593002: rAc: don't DCHECK() when switching from Wallet -> Autofill with only 1 name.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 229593002: rAc: don't DCHECK() when switching from Wallet -> Autofill with only 1 name. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: asdf Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

index 188f72c2ed56d1f8e52fccd8a70cb138e15ff676..1ad6482abb1682051476c7f031af0cbd43927fa5 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

@@ -1812,9 +1812,8 @@ base::string16 AutofillDialogControllerImpl::InputValidityMessage(

case NAME_FULL:

// Wallet requires a first and last billing name.

- if (section == SECTION_CC_BILLING && !value.empty() &&

+ if (IsPayingWithWallet() && !value.empty() &&

!IsCardHolderNameValidForWallet(value)) {

- DCHECK(IsPayingWithWallet());

return l10n_util::GetStringUTF16(

IDS_AUTOFILL_DIALOG_VALIDATION_WALLET_REQUIRES_TWO_NAMES);

}

« no previous file with comments | « no previous file | chrome/browser/ui/autofill/autofill_dialog_controller_unittest.cc » ('j') | no next file with comments »