gfx: Struct traits for GpuMemoryBufferId and GpuMemoryBufferType.

gfx: Struct traits for GpuMemoryBufferId and GpuMemoryBufferType.

BUG=637923
Committed: https://crrev.com/900faab623165140c2c34f7ba94cced55769691c
Cr-Commit-Position: refs/heads/master@{#415521}

[sadrul, 2016-08-30 18:01:42]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 18:02:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-30 18:22:52]

sadrul@chromium.org changed reviewers:
+ tsepez@chromium.org

[Fady Samuel, 2016-08-30 18:27:06]

fsamuel@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2016-08-30 18:27:07]

https://codereview.chromium.org/2295923002/diff/20001/ui/gfx/mojo/buffer_type...
File ui/gfx/mojo/buffer_types.typemap (right):

https://codereview.chromium.org/2295923002/diff/20001/ui/gfx/mojo/buffer_type...
ui/gfx/mojo/buffer_types.typemap:17:
"gfx.mojom.GpuMemoryBufferId=gfx::GpuMemoryBufferId",
use copyable_pass_by_value to avoid extra const refs since this is really just
an int:
https://cs.chromium.org/chromium/src/mojo/public/cpp/bindings/struct_traits.h...

It'll save you a few cycles here and there.

[Fady Samuel, 2016-08-30 18:28:15]

https://codereview.chromium.org/2295923002/diff/20001/ui/gfx/mojo/buffer_type...
File ui/gfx/mojo/buffer_types_enum_traits.h (right):

https://codereview.chromium.org/2295923002/diff/20001/ui/gfx/mojo/buffer_type...
ui/gfx/mojo/buffer_types_enum_traits.h:5: #ifndef
UI_GFX_MOJO_BUFFER_TYPES_ENUM_TRAITS_H_
bikeshedding name: these are no longer just enum traits? Should we call this
file traits?

[Tom Sepez, 2016-08-30 18:32:50]

lgtm

[sadrul, 2016-08-30 18:33:15]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 18:34:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sadrul, 2016-08-30 18:35:24]

https://codereview.chromium.org/2295923002/diff/20001/ui/gfx/mojo/buffer_type...
File ui/gfx/mojo/buffer_types.typemap (right):

https://codereview.chromium.org/2295923002/diff/20001/ui/gfx/mojo/buffer_type...
ui/gfx/mojo/buffer_types.typemap:17:
"gfx.mojom.GpuMemoryBufferId=gfx::GpuMemoryBufferId",
On 2016/08/30 18:27:07, Fady Samuel wrote:
> use copyable_pass_by_value to avoid extra const refs since this is really just
> an int:
>
https://cs.chromium.org/chromium/src/mojo/public/cpp/bindings/struct_traits.h...
> 
> It'll save you a few cycles here and there.

Done.

https://codereview.chromium.org/2295923002/diff/20001/ui/gfx/mojo/buffer_type...
File ui/gfx/mojo/buffer_types_enum_traits.h (right):

https://codereview.chromium.org/2295923002/diff/20001/ui/gfx/mojo/buffer_type...
ui/gfx/mojo/buffer_types_enum_traits.h:5: #ifndef
UI_GFX_MOJO_BUFFER_TYPES_ENUM_TRAITS_H_
On 2016/08/30 18:28:15, Fady Samuel wrote:
> bikeshedding name: these are no longer just enum traits? Should we call this
> file traits?

Done.

[commit-bot: I haz the power, 2016-08-30 19:01:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 19:01:29]

Dry run: Exceeded global retry quota

[sadrul, 2016-08-30 19:11:31]

The CQ bit was checked by sadrul@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 19:12:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:25:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 20:25:30]

Dry run: This issue passed the CQ dry run.

[Fady Samuel, 2016-08-30 20:35:49]

lgtm

[sadrul, 2016-08-30 20:37:09]

The CQ bit was checked by sadrul@chromium.org

[sadrul, 2016-08-30 20:37:09]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2295923002/#ps60001
(title: "fix build")

[commit-bot: I haz the power, 2016-08-30 20:37:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 20:47:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 20:47:16]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[sadrul, 2016-08-30 22:52:09]

sadrul@chromium.org changed reviewers:
+ sky@chromium.org

[sadrul, 2016-08-30 22:52:10]

+sky@ for ws owner

[sky, 2016-08-31 00:04:41]

LGTM

[sadrul, 2016-08-31 00:35:49]

The CQ bit was checked by sadrul@chromium.org

[commit-bot: I haz the power, 2016-08-31 00:36:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 00:40:23]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-31 00:42:53]

Description was changed from

==========
gfx: Struct traits for GpuMemoryBufferId and GpuMemoryBufferType.

BUG=637923
==========

to

==========
gfx: Struct traits for GpuMemoryBufferId and GpuMemoryBufferType.

BUG=637923

Committed: https://crrev.com/900faab623165140c2c34f7ba94cced55769691c
Cr-Commit-Position: refs/heads/master@{#415521}
==========

[commit-bot: I haz the power, 2016-08-31 00:42:56]

Patchset 4 (id:??) landed as
https://crrev.com/900faab623165140c2c34f7ba94cced55769691c
Cr-Commit-Position: refs/heads/master@{#415521}