ui/gfx/mojo/buffer_types.typemap - Issue 2295923002: gfx: Struct traits for GpuMemoryBufferId and GpuMemoryBufferType.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/mojo/buffer_types.typemap

Issue 2295923002: gfx: Struct traits for GpuMemoryBufferId and GpuMemoryBufferType. (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 mojom = "//ui/gfx/mojo/buffer_types.mojom"	5 mojom = "//ui/gfx/mojo/buffer_types.mojom"

6 public_headers = [ "//ui/gfx/buffer_types.h" ]	6 public_headers = [

	7 "//ui/gfx/buffer_types.h",

	8 "//ui/gfx/gpu_memory_buffer.h",

	9 ]

7 traits_headers = [ "//ui/gfx/mojo/buffer_types_enum_traits.h" ]	10 traits_headers = [ "//ui/gfx/mojo/buffer_types_enum_traits.h" ]

8 public_deps = [	11 public_deps = [

9 "//ui/gfx",	12 "//ui/gfx",

10 ]	13 ]

11 type_mappings = [	14 type_mappings = [

12 "gfx.mojom.BufferFormat=gfx::BufferFormat",	15 "gfx.mojom.BufferFormat=gfx::BufferFormat",

13 "gfx.mojom.BufferUsage=gfx::BufferUsage",	16 "gfx.mojom.BufferUsage=gfx::BufferUsage",

	17 "gfx.mojom.GpuMemoryBufferId=gfx::GpuMemoryBufferId",
	Fady Samuel 2016/08/30 18:27:07 use copyable_pass_by_value to avoid extra const re use copyable_pass_by_value to avoid extra const refs since this is really just an int: https://cs.chromium.org/chromium/src/mojo/public/cpp/bindings/struct_traits.h... It'll save you a few cycles here and there. sadrul 2016/08/30 18:35:23 Done. Show quoted text On 2016/08/30 18:27:07, Fady Samuel wrote: > use copyable_pass_by_value to avoid extra const refs since this is really just > an int: > https://cs.chromium.org/chromium/src/mojo/public/cpp/bindings/struct_traits.h... > > It'll save you a few cycles here and there. Done.
	18 "gfx.mojom.GpuMemoryBufferType=gfx::GpuMemoryBufferType",

14 ]	19 ]

OLD	NEW

« no previous file with comments | « ui/gfx/mojo/buffer_types.mojom ('k') | ui/gfx/mojo/buffer_types_enum_traits.h » ('j') | ui/gfx/mojo/buffer_types_enum_traits.h » ('J')