systrace/profile_chrome/atrace_tracing_agent_unittest.py - Issue 2295913002: Enable some profile_chrome unit tests on Trybots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: systrace/profile_chrome/atrace_tracing_agent_unittest.py

Issue 2295913002: Enable some profile_chrome unit tests on Trybots (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master

Patch Set: Add never-run decorator to perf agent as well Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« systrace/profile_chrome/agents_unittest.py ('K') | « systrace/profile_chrome/agents_unittest.py ('k') | systrace/profile_chrome/chrome_startup_tracing_agent_unittest.py » ('j') | systrace/systrace/decorators.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: systrace/profile_chrome/atrace_tracing_agent_unittest.py

diff --git a/systrace/profile_chrome/atrace_tracing_agent_unittest.py b/systrace/profile_chrome/atrace_tracing_agent_unittest.py

index 8ec9ebca8b42de2637eeebe347012cb188209725..2b365b453e4aa8d5290b2849334729179a94c50b 100644

--- a/systrace/profile_chrome/atrace_tracing_agent_unittest.py

+++ b/systrace/profile_chrome/atrace_tracing_agent_unittest.py

@@ -4,15 +4,18 @@

from profile_chrome import agents_unittest

from profile_chrome import atrace_tracing_agent

+from systrace import decorators

class AtraceAgentTest(agents_unittest.BaseAgentTest):

+ @decorators.ClientOnlyTest

def testGetCategories(self):

categories = \

atrace_tracing_agent.AtraceAgent.GetCategories(self.device)

self.assertTrue(categories)

assert 'gfx' in ' '.join(categories)

+ @decorators.NeverRunTest

Sami 2016/09/02 13:01:13 For each completely disabled test, could you add a

washingtonp 2016/09/08 22:51:36 Done.

def testTracing(self):

categories = 'gfx,input,view'

ring_buffer = False