Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Side by Side Diff: systrace/profile_chrome/atrace_tracing_agent_unittest.py

Issue 2295913002: Enable some profile_chrome unit tests on Trybots (Closed) Base URL: https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git@master
Patch Set: Add never-run decorator to perf agent as well Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from profile_chrome import agents_unittest 5 from profile_chrome import agents_unittest
6 from profile_chrome import atrace_tracing_agent 6 from profile_chrome import atrace_tracing_agent
7 from systrace import decorators
7 8
8 9
9 class AtraceAgentTest(agents_unittest.BaseAgentTest): 10 class AtraceAgentTest(agents_unittest.BaseAgentTest):
11 @decorators.ClientOnlyTest
10 def testGetCategories(self): 12 def testGetCategories(self):
11 categories = \ 13 categories = \
12 atrace_tracing_agent.AtraceAgent.GetCategories(self.device) 14 atrace_tracing_agent.AtraceAgent.GetCategories(self.device)
13 self.assertTrue(categories) 15 self.assertTrue(categories)
14 assert 'gfx' in ' '.join(categories) 16 assert 'gfx' in ' '.join(categories)
15 17
18 @decorators.NeverRunTest
Sami 2016/09/02 13:01:13 For each completely disabled test, could you add a
washingtonp 2016/09/08 22:51:36 Done.
16 def testTracing(self): 19 def testTracing(self):
17 categories = 'gfx,input,view' 20 categories = 'gfx,input,view'
18 ring_buffer = False 21 ring_buffer = False
19 agent = atrace_tracing_agent.AtraceAgent(self.device, 22 agent = atrace_tracing_agent.AtraceAgent(self.device,
20 ring_buffer) 23 ring_buffer)
21 24
22 try: 25 try:
23 agent.StartAgentTracing(atrace_tracing_agent.AtraceConfig(categories)) 26 agent.StartAgentTracing(atrace_tracing_agent.AtraceConfig(categories))
24 finally: 27 finally:
25 agent.StopAgentTracing() 28 agent.StopAgentTracing()
26 result = agent.GetResults() 29 result = agent.GetResults()
27 30
28 self.assertFalse(agent.IsTracingOn()) 31 self.assertFalse(agent.IsTracingOn())
29 self.assertTrue('CPU#' in result.raw_data) 32 self.assertTrue('CPU#' in result.raw_data)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698