Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2295653002: Use window.testRunner in if-clause (Closed)

Created:
4 years, 3 months ago by tyoshino (SeeGerritForStatus)
Modified:
4 years, 3 months ago
Reviewers:
yhirano
CC:
chromium-reviews, shans, tzik, posciak+watch_chromium.org, eric.carlson_apple.com, dmazzoni+watch_chromium.org, aboxhall, aboxhall+watch_chromium.org, je_julie, blink-reviews, Eric Willigers, rjwright, Peter Beverloo, yuzo+watch_chromium.org, feature-media-reviews_chromium.org, dmazzoni, nhiroki, darktears, mlamouri+watch-blink_chromium.org, blink-reviews-animation_chromium.org, nektar+watch_chromium.org, nektarios, dtseng+watch_chromium.org, kinuko+fileapi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use window.testRunner in if-clause "if (testRunner)" throws if testRunner is undefined. BUG=none Committed: https://crrev.com/62feae56f73c42ddf5b7b0b2cab6f685f4d5cf51 Cr-Commit-Position: refs/heads/master@{#415232}

Patch Set 1 #

Patch Set 2 : a #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M third_party/WebKit/LayoutTests/accessibility/insert-adjacent-html-causes-crash.xhtml View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-iframes.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/dont-squash-into-videos.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/compositing/squashing/iframes-are-never-squashed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/block/float/overhanging-float-overflow-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/counters/counter-before-content-not-incremented.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/local_font_invalid.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/image-src-onerror.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/image-srcset-invalid-url-no-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/HTMLImageElement/image-srcset-w-onerror.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/custom/reparent-unwrapped-custom-element-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/dynamic/position-absolute-to-fixed-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/filesystem/file-metadata-after-write.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/date/date-appearance-basic.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/forms/date/date-reset-value.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/iframe-plugin-load-remove-document-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/frames/resources/meta-refresh-target.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/harness/internals-object.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/harness/user-preferred-language.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/history/history-back-twice-with-subframes-assert.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/inline/reparent-inline-box.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/script-tests/cross-frame-bad-time.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/script-tests/cross-frame-really-bad-time.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/script-tests/cross-frame-really-bad-time-with-__proto__.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/serviceworker/access-container-with-invalid-context.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/text-autosizing/empty-document-crash.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/writing-mode/broken-ideographic-font.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-frameset.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-request-rejected.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fullscreen/full-screen-request-removed.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/misc/delete-frame-during-readystatechange-with-gc-after-video-removal.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-paint-invalidation.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/custom/pattern-empty-bbox-2.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/svg/dom/viewport-container-crash.svg View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/transitions/hang-with-bad-transition-list.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
tyoshino (SeeGerritForStatus)
4 years, 3 months ago (2016-08-30 05:49:50 UTC) #3
yhirano
lgtm
4 years, 3 months ago (2016-08-30 05:53:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295653002/20001
4 years, 3 months ago (2016-08-30 05:56:45 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-08-30 07:29:01 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 07:31:06 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/62feae56f73c42ddf5b7b0b2cab6f685f4d5cf51
Cr-Commit-Position: refs/heads/master@{#415232}

Powered by Google App Engine
This is Rietveld 408576698