third_party/WebKit/LayoutTests/fast/dynamic/position-absolute-to-fixed-crash.html - Issue 2295653002: Use window.testRunner in if-clause

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dynamic/position-absolute-to-fixed-crash.html

Issue 2295653002: Use window.testRunner in if-clause (Closed)

Patch Set: a Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <head>	1 <head>

2 <script>	2 <script>

3 if (testRunner)	3 if (window.testRunner)

4 testRunner.dumpAsText();	4 testRunner.dumpAsText();

5	5

6 function test()	6 function test()

7 {	7 {

8 document.body.offsetTop;	8 document.body.offsetTop;

9 var s = document.getElementById("target").style;	9 var s = document.getElementById("target").style;

10 s.setProperty("position", "fixed");	10 s.setProperty("position", "fixed");

11 document.body.offsetTop;	11 document.body.offsetTop;

12 s.setProperty("overflow", "hidden");	12 s.setProperty("overflow", "hidden");

13 s.setProperty("height", "0");	13 s.setProperty("height", "0");

(...skipping 12 matching lines...) Expand all Loading...
26 This crash occurred after an object’s position changed directly	26 This crash occurred after an object’s position changed directly

27 from absolute to fixed, and it was not added to the LayoutView’s	27 from absolute to fixed, and it was not added to the LayoutView’s

28 positioned objects list nor removed from its old container’s list.	28 positioned objects list nor removed from its old container’s list.

29 </p>	29 </p>

30 <div style="position: relative;">	30 <div style="position: relative;">

31 <div id="target" style="top: 50px; position: absolute;">	31 <div id="target" style="top: 50px; position: absolute;">

32 <div style="height: 50px; width: 50px; background-color: red;"></div >	32 <div style="height: 50px; width: 50px; background-color: red;"></div >

33 </div>	33 </div>

34 </div>	34 </div>

35 </body>	35 </body>

OLD	NEW