DevTools: simplify http handler delegate as it is moving into content.

DevTools: simplify http handler delegate as it is moving into content.

BUG=627517
TBR= for handler clients.

Committed: https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019
Cr-Commit-Position: refs/heads/master@{#416345}

[pfeldman, 2016-08-30 23:19:59]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-08-30 23:20:25]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 23:21:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 23:29:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 23:29:45]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-08-30 23:41:22]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 23:42:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 23:53:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 23:53:01]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-08-31 00:18:10]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 00:18:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 00:30:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 00:30:52]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-09-01 19:27:44]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 19:28:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 19:37:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 19:37:20]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-09-01 21:01:12]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 21:01:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 21:13:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 21:13:58]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[pfeldman, 2016-09-01 23:24:05]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 23:24:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-09-02 00:05:26]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-02 00:05:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-09-02 00:40:47]

Patchset #7 (id:120001) has been deleted

[pfeldman, 2016-09-02 00:40:55]

Patchset #6 (id:100001) has been deleted

[pfeldman, 2016-09-02 00:41:04]

Patchset #5 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-09-02 01:12:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 01:12:32]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-09-02 18:25:45]

lgtm

https://codereview.chromium.org/2295623002/diff/140001/content/public/browser...
File content/public/browser/devtools_socket_factory.h (right):

https://codereview.chromium.org/2295623002/diff/140001/content/public/browser...
content/public/browser/devtools_socket_factory.h:1: // Copyright (c) 2016 The
Chromium Authors. All rights reserved.
no (c)

https://codereview.chromium.org/2295623002/diff/140001/content/public/browser...
content/public/browser/devtools_socket_factory.h:19: public:
Please reformat.

[pfeldman, 2016-09-02 18:56:33]

Description was changed from

==========
DevTools: move devtools_http_handler into content.

BUG=
==========

to

==========
DevTools: simplify http handler delegate as it is moving into content.

BUG=627517
TBR= for handler clients.
==========

[pfeldman, 2016-09-02 18:59:21]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-09-02 18:59:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2295623002/#ps160001
(title: "lcean")

[commit-bot: I haz the power, 2016-09-02 18:59:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 21:28:17]

Description was changed from

==========
DevTools: simplify http handler delegate as it is moving into content.

BUG=627517
TBR= for handler clients.
==========

to

==========
DevTools: simplify http handler delegate as it is moving into content.

BUG=627517
TBR= for handler clients.
==========

[commit-bot: I haz the power, 2016-09-02 21:28:18]

Committed patchset #6 (id:160001)

[commit-bot: I haz the power, 2016-09-02 21:31:10]

Description was changed from

==========
DevTools: simplify http handler delegate as it is moving into content.

BUG=627517
TBR= for handler clients.
==========

to

==========
DevTools: simplify http handler delegate as it is moving into content.

BUG=627517
TBR= for handler clients.

Committed: https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019
Cr-Commit-Position: refs/heads/master@{#416345}
==========

[commit-bot: I haz the power, 2016-09-02 21:31:11]

Patchset 6 (id:??) landed as
https://crrev.com/f1a1694bef83721d4a2e1bb9e6399e57a4e1a019
Cr-Commit-Position: refs/heads/master@{#416345}