Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: content/public/browser/devtools_socket_factory.h

Issue 2295623002: DevTools: simplify http handler delegate as it is moving into content. (Closed)
Patch Set: lcean Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/content_browser.gypi ('k') | content/shell/browser/shell_devtools_frontend.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/devtools_socket_factory.h
diff --git a/content/public/browser/devtools_socket_factory.h b/content/public/browser/devtools_socket_factory.h
new file mode 100644
index 0000000000000000000000000000000000000000..d1d543549dbf9fa3a19aecf501b5659c5e99a643
--- /dev/null
+++ b/content/public/browser/devtools_socket_factory.h
@@ -0,0 +1,33 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_PUBLIC_BROWSER_DEVTOOLS_SOCKET_FACTORY_H_
+#define CONTENT_PUBLIC_BROWSER_DEVTOOLS_SOCKET_FACTORY_H_
+
+#include <string>
+
+#include "net/socket/server_socket.h"
+
+namespace content {
+
+// Factory of net::ServerSocket. This is to separate instantiating dev tools
+// and instantiating server sockets.
+// All methods including destructor are called on a separate thread
+// different from any BrowserThread instance.
+class DevToolsSocketFactory {
+ public:
+ virtual ~DevToolsSocketFactory() {}
+
+ // Returns a new instance of ServerSocket or nullptr if an error occurred.
+ virtual std::unique_ptr<net::ServerSocket> CreateForHttpServer() = 0;
+
+ // Creates a named socket for reversed tethering implementation (used with
+ // remote debugging, primarily for mobile).
+ virtual std::unique_ptr<net::ServerSocket> CreateForTethering(
+ std::string* out_name) = 0;
+ };
+
+} // namespace content
+
+#endif // CONTENT_PUBLIC_BROWSER_DEVTOOLS_SOCKET_FACTORY_H_
« no previous file with comments | « content/content_browser.gypi ('k') | content/shell/browser/shell_devtools_frontend.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698