exo: Hide cursor for direct input

exo: Hide cursor for direct input

Exosphere renders its own cursor which does not get hidden by the
global logic to hide a cursor when using direct input mouse events.

This CL will make sure the cursor widget gets hidden or restored
depending whether direct input is used or not.

BUG=636458
TEST=use direct input in exo app. Cursor should be hidden.

Committed: https://crrev.com/43f06b3247dc494647ea6358061e90e63c35e64c
Cr-Commit-Position: refs/heads/master@{#415326}

[denniskempin, 2016-08-29 22:13:47]

denniskempin@google.com changed reviewers:
+ reveman@chromium.org

[denniskempin, 2016-08-29 22:13:47]

PTAL David!

I was thinking about doing this on the client-side. However there seem to be
synchronization issues that show the cursor jump to a new location before hiding
it. The safest way I have found to leave chrome in control of hiding the cursor
when using direct input and hide the cursor widget in exo. 
Unfortunately there is still an occasional rare glitch where the cursor will be
shown at the new location for a single frame before disappearing. Not entirely
sure what to do about it, but this is a good enough solution for now.

[reveman, 2016-08-29 22:34:08]

https://codereview.chromium.org/2295513002/diff/1/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2295513002/diff/1/components/exo/pointer.cc#n...
components/exo/pointer.cc:263: if (event->flags() & ui::EF_DIRECT_INPUT) {
Can we move this check to line 255 instead? ie. (focus_ && (event->flags() &
ui::EF_DIRECT_INPUT) == 0))

Do we need to update line 106 too?

[denniskempin, 2016-08-30 00:28:11]

had to change the code quite a bit but I think this is much better.

https://codereview.chromium.org/2295513002/diff/1/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2295513002/diff/1/components/exo/pointer.cc#n...
components/exo/pointer.cc:263: if (event->flags() & ui::EF_DIRECT_INPUT) {
On 2016/08/29 22:34:08, reveman wrote:
> Can we move this check to line 255 instead? ie. (focus_ && (event->flags() &
> ui::EF_DIRECT_INPUT) == 0))
> 
> Do we need to update line 106 too?

Done.

[reveman, 2016-08-30 00:40:49]

https://codereview.chromium.org/2295513002/diff/40001/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2295513002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:255: is_direct_input_ = (event->flags() &
ui::EF_DIRECT_INPUT) != 0;
should we really take "focus_" into account here? how about:

is_direct_input_ = (event->flags() & ui::EF_DIRECT_INPUT) &&
                   ((event->flags() & ui::EF_IS_SYNTHESIZED) == 0);

https://codereview.chromium.org/2295513002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:270: widget_->Show();
nit: move below UpdateCursorScale() as better to show at the correct scale right
away

[denniskempin, 2016-08-30 00:47:25]

https://codereview.chromium.org/2295513002/diff/40001/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2295513002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:255: is_direct_input_ = (event->flags() &
ui::EF_DIRECT_INPUT) != 0;
On 2016/08/30 00:40:49, reveman wrote:
> should we really take "focus_" into account here? how about:
> 
> is_direct_input_ = (event->flags() & ui::EF_DIRECT_INPUT) &&
>                    ((event->flags() & ui::EF_IS_SYNTHESIZED) == 0);

I removed the check for focus_,  but we do need the if since synthesized events
should not affect the direct input flag. 
Otherwise we will flip the direct_input flag back and forth when using direct
input, causing a flickering cursor. (something about moving the cursor the way
exo does seems to generate synthesized mouse events).

https://codereview.chromium.org/2295513002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:270: widget_->Show();
On 2016/08/30 00:40:49, reveman wrote:
> nit: move below UpdateCursorScale() as better to show at the correct scale
right
> away

Done.

[reveman, 2016-08-30 00:49:43]

lgtm

https://codereview.chromium.org/2295513002/diff/40001/components/exo/pointer.cc
File components/exo/pointer.cc (right):

https://codereview.chromium.org/2295513002/diff/40001/components/exo/pointer....
components/exo/pointer.cc:255: is_direct_input_ = (event->flags() &
ui::EF_DIRECT_INPUT) != 0;
On 2016/08/30 at 00:47:25, denniskempin wrote:
> On 2016/08/30 00:40:49, reveman wrote:
> > should we really take "focus_" into account here? how about:
> > 
> > is_direct_input_ = (event->flags() & ui::EF_DIRECT_INPUT) &&
> >                    ((event->flags() & ui::EF_IS_SYNTHESIZED) == 0);
> 
> I removed the check for focus_,  but we do need the if since synthesized
events should not affect the direct input flag. 
> Otherwise we will flip the direct_input flag back and forth when using direct
input, causing a flickering cursor. (something about moving the cursor the way
exo does seems to generate synthesized mouse events).

Got it. Makes sense.

[denniskempin, 2016-08-30 16:11:20]

The CQ bit was checked by denniskempin@google.com

[commit-bot: I haz the power, 2016-08-30 16:11:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 16:56:38]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-30 16:58:25]

Description was changed from

==========
exo: Hide cursor for direct input

Exosphere renders its own cursor which does not get hidden by the
global logic to hide a cursor when using direct input mouse events.

This CL will make sure the cursor widget gets hidden or restored
depending whether direct input is used or not.

BUG=636458
TEST=use direct input in exo app. Cursor should be hidden.
==========

to

==========
exo: Hide cursor for direct input

Exosphere renders its own cursor which does not get hidden by the
global logic to hide a cursor when using direct input mouse events.

This CL will make sure the cursor widget gets hidden or restored
depending whether direct input is used or not.

BUG=636458
TEST=use direct input in exo app. Cursor should be hidden.

Committed: https://crrev.com/43f06b3247dc494647ea6358061e90e63c35e64c
Cr-Commit-Position: refs/heads/master@{#415326}
==========

[commit-bot: I haz the power, 2016-08-30 16:58:27]

Patchset 4 (id:??) landed as
https://crrev.com/43f06b3247dc494647ea6358061e90e63c35e64c
Cr-Commit-Position: refs/heads/master@{#415326}