exo: Hide cursor for direct input

components/exo/pointer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/exo/pointer.h"
 
 #include "ash/common/display/display_info.h"
 #include "ash/common/shell_window_ids.h"
 #include "ash/display/display_manager.h"
 #include "components/exo/pointer_delegate.h"
@@ skipping 85 matching lines @@
   // Update hotspot and show cursor surface if not already visible.
   hotspot_ = hotspot;
   if (surface_) {
     surface_->window()->SetBounds(
         gfx::Rect(gfx::Point() - hotspot_.OffsetFromOrigin(),
                   surface_->window()->layer()->size()));
     if (!surface_->window()->IsVisible())
       surface_->window()->Show();
 
     // Show widget now that cursor has been defined.
-    if (!widget_->IsVisible())
+    if (!widget_->IsVisible() && !is_direct_input_)
       widget_->Show();
   }
 
   // Register pointer as cursor provider now that the cursor for |focus_| has
   // been defined.
   focus_->RegisterCursorProvider(this);
 
   // Update cursor in case the registration of pointer as cursor provider
   // caused the cursor to change.
   aura::client::CursorClient* cursor_client =
@@ skipping 127 matching lines @@
       break;
     case ui::ET_MOUSE_ENTERED:
     case ui::ET_MOUSE_EXITED:
     case ui::ET_MOUSE_CAPTURE_CHANGED:
       break;
     default:
       NOTREACHED();
       break;
   }
 
+  if (focus_ && (event->flags() & ui::EF_IS_SYNTHESIZED) == 0)
+    is_direct_input_ = (event->flags() & ui::EF_DIRECT_INPUT) != 0;

[reveman, 2016/08/30 00:40:49]

should we really take "focus_" into account here? how about:

is_direct_input_ = (event->flags() & ui::EF_DIRECT_INPUT) &&
                   ((event->flags() & ui::EF_IS_SYNTHESIZED) == 0);

[denniskempin, 2016/08/30 00:47:25]

I removed the check for focus_,  but we do need the if since synthesized events
should not affect the direct input flag. 
Otherwise we will flip the direct_input flag back and forth when using direct
input, causing a flickering cursor. (something about moving the cursor the way
exo does seems to generate synthesized mouse events). 

[reveman, 2016/08/30 00:49:43]

Got it. Makes sense.

+
   // Update cursor widget to reflect current focus and pointer location.
-  if (focus_) {
+  if (focus_ && !is_direct_input_) {
     if (!widget_)
       CreatePointerWidget();
 
     // Update cursor location if mouse event caused it to change.
     gfx::Point mouse_location = aura::Env::GetInstance()->last_mouse_location();
     gfx::Rect bounds = widget_->GetWindowBoundsInScreen();
     if (mouse_location != bounds.origin()) {
       bounds.set_origin(mouse_location);
       widget_->SetBounds(bounds);
     }
+    if (!widget_->IsVisible())
+      widget_->Show();

[reveman, 2016/08/30 00:40:49]

nit: move below UpdateCursorScale() as better to show at the correct scale right
away

[denniskempin, 2016/08/30 00:47:25]

Done.

 
     UpdateCursorScale();
   } else {
     if (widget_ && widget_->IsVisible())
       widget_->Hide();
   }
 }
 
 void Pointer::OnScrollEvent(ui::ScrollEvent* event) {
   OnMouseEvent(event);
@@ skipping 76 matching lines @@
 
   if (ui_scale != cursor_scale_) {
     gfx::Transform transform;
     transform.Scale(ui_scale, ui_scale);
     widget_->GetNativeWindow()->SetTransform(transform);
     cursor_scale_ = ui_scale;
   }
 }
 
 }  // namespace exo