Source/web/WebViewImpl.cpp - Issue 22955006: Chrome::client() should return a ChromeClient reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebViewImpl.cpp

Issue 22955006: Chrome::client() should return a ChromeClient reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/web/WebViewImpl.cpp

diff --git a/Source/web/WebViewImpl.cpp b/Source/web/WebViewImpl.cpp

index e9deda3d5eeb72964a8914373a084910fb5ba4d6..10d6072d6859fe9ef26c763c8bdeb9ba5266b1f5 100644

--- a/Source/web/WebViewImpl.cpp

+++ b/Source/web/WebViewImpl.cpp

@@ -1594,9 +1594,7 @@ WebViewImpl* WebViewImpl::fromPage(Page* page)

{

if (!page)

return 0;

- ChromeClientImpl* chromeClient = static_cast<ChromeClientImpl*>(page->chrome().client());

- return static_cast<WebViewImpl*>(chromeClient->webView());

+ return static_cast<WebViewImpl*>(page->chrome().client().webView());

}

// WebWidget ------------------------------------------------------------------

« no previous file with comments | « Source/web/WebPluginContainerImpl.cpp ('k') | Source/web/tests/ChromeClientImplTest.cpp » ('j') | no next file with comments »