[chromedriver] Added option to make element references W3C compliant.

[chromedriver] Added option to make element references W3C compliant.

This patch is done on behalf of roisinmcl@chromium.org (original work in
https://codereview.chromium.org/2230053002/).

When a chromedrvier session is created with a flag for W3C compliance,
chromedriver will reference the element with a UUID in place of the
existing ID generation method.

Chromedriver wrapping/unwrapping functions have been changed to match
the new referencing when the W3C flag is true.

BUG=

Committed: https://crrev.com/f2f2146a3f18c7596da37087662f0aeec3b09bfd
Cr-Commit-Position: refs/heads/master@{#434753}

[samuong, 2016-08-29 21:29:37]

samuong@chromium.org changed reviewers:
+ stgao@chromium.org

[samuong, 2016-08-29 21:29:38]

ptal

[vinodsonkusare77_gmail.com, 2016-08-30 06:35:49]

https://youtu.be/ZB29OFBS2w8?list=UUWQUZfAdokV83KKjLl-sDeQ

On Tue, Aug 30, 2016 at 2:59 AM, <samuong@chromium.org> wrote:

> Reviewers: stgao
> CL: https://codereview.chromium.org/2295443003/
>
> Message:
> ptal
>
> Description:
> [chromedriver] Added option to make element references W3C compliant.
>
> This patch is done on behalf of roisinmcl@chromium.org (original work in
> https://codereview.chromium.org/2230053002/).
>
> When a chromedrvier session is created with a flag for W3C compliance,
> chromedriver will reference the element with a UUID in place of the
> existing ID generation method.
>
> Chromedriver wrapping/unwrapping functions have been changed to match
> the new referencing when the W3C flag is true.
>
> BUG=
>
> Affected files (+264, -66 lines):
> M chrome/test/chromedriver/chrome/chrome.h
> M chrome/test/chromedriver/chrome/chrome_desktop_impl.h
> M chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
> M chrome/test/chromedriver/chrome/chrome_impl.h
> M chrome/test/chromedriver/chrome/chrome_impl.cc
> M chrome/test/chromedriver/chrome/devtools_http_client.cc
> M chrome/test/chromedriver/chrome/stub_chrome.h
> M chrome/test/chromedriver/chrome/stub_chrome.cc
> M chrome/test/chromedriver/chrome/web_view_impl.h
> M chrome/test/chromedriver/chrome/web_view_impl.cc
> M chrome/test/chromedriver/chrome_launcher.h
> M chrome/test/chromedriver/chrome_launcher.cc
> M chrome/test/chromedriver/client/chromedriver.py
> M chrome/test/chromedriver/commands.cc
> M chrome/test/chromedriver/element_util.cc
> M chrome/test/chromedriver/js/call_function.js
> M chrome/test/chromedriver/js/call_function_test.html
> M chrome/test/chromedriver/session_commands.cc
> M chrome/test/chromedriver/test/run_py_tests.py
> M chrome/test/chromedriver/window_commands.cc
> A chrome/test/data/chromedriver/element_ref.html
> M chrome/test/data/chromedriver/orientation_test.html
>
>
> --
> You received this message because you are subscribed to the Google Groups
> "DevTools Reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to devtools-reviews+unsubscribe@chromium.org.
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[stgao, 2016-08-31 18:26:17]

lgtm with a suggestion that could be done in a follow-up CL if it makes sense.

https://codereview.chromium.org/2295443003/diff/1/chrome/test/chromedriver/js...
File chrome/test/chromedriver/js/call_function.js (right):

https://codereview.chromium.org/2295443003/diff/1/chrome/test/chromedriver/js...
chrome/test/chromedriver/js/call_function.js:76: CacheWithUUID.prototype = {
It seems that CacheWithUUID and Cache could share a lot of code, as the
difference is only the generation of the element reference id.

It would be great if they could be merged together to avoid duplicate code.

https://codereview.chromium.org/2295443003/diff/1/chrome/test/chromedriver/te...
File chrome/test/chromedriver/test/run_py_tests.py (right):

https://codereview.chromium.org/2295443003/diff/1/chrome/test/chromedriver/te...
chrome/test/chromedriver/test/run_py_tests.py:1297: print element._id
nit: delete print.

[samuong, 2016-11-23 22:48:45]

https://codereview.chromium.org/2295443003/diff/1/chrome/test/chromedriver/js...
File chrome/test/chromedriver/js/call_function.js (right):

https://codereview.chromium.org/2295443003/diff/1/chrome/test/chromedriver/js...
chrome/test/chromedriver/js/call_function.js:76: CacheWithUUID.prototype = {
On 2016/08/31 18:26:16, stgao (slow on Monday) wrote:
> It seems that CacheWithUUID and Cache could share a lot of code, as the
> difference is only the generation of the element reference id.
> 
> It would be great if they could be merged together to avoid duplicate code.

I think this makes sense for a follow-up CL, as you suggested.

https://codereview.chromium.org/2295443003/diff/1/chrome/test/chromedriver/te...
File chrome/test/chromedriver/test/run_py_tests.py (right):

https://codereview.chromium.org/2295443003/diff/1/chrome/test/chromedriver/te...
chrome/test/chromedriver/test/run_py_tests.py:1297: print element._id
On 2016/08/31 18:26:16, stgao (slow on Monday) wrote:
> nit: delete print.

Done.

[samuong, 2016-11-23 22:48:52]

The CQ bit was checked by samuong@chromium.org

[samuong, 2016-11-23 22:48:52]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2295443003/#ps20001
(title: "delete print statement, rebase")

[commit-bot: I haz the power, 2016-11-23 22:50:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-23 23:08:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-23 23:08:36]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[samuong, 2016-11-23 23:17:49]

Patchset #3 (id:40001) has been deleted

[samuong, 2016-11-23 23:25:15]

The CQ bit was checked by samuong@chromium.org

[samuong, 2016-11-23 23:25:16]

The patchset sent to the CQ was uploaded after l-g-t-m from stgao@chromium.org
Link to the patchset: https://codereview.chromium.org/2295443003/#ps60001
(title: "fix errors introduced during previous rebase")

[commit-bot: I haz the power, 2016-11-23 23:26:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-24 01:28:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-24 01:28:31]

Try jobs failed on following builders:
  blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)

[samuong, 2016-11-28 17:44:41]

The CQ bit was checked by samuong@chromium.org

[commit-bot: I haz the power, 2016-11-28 17:45:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-28 22:50:08]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480355081108090,
"parent_rev": "5e3b3c9ea552128ec375aefc1323eac3bf39419e", "commit_rev":
"4fd3ac90a3f640c171dbfbb00988d0adf94ab3bb"}

[commit-bot: I haz the power, 2016-11-28 22:50:32]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-11-28 22:52:43]

Description was changed from

==========
[chromedriver] Added option to make element references W3C compliant.

This patch is done on behalf of roisinmcl@chromium.org (original work in
https://codereview.chromium.org/2230053002/).

When a chromedrvier session is created with a flag for W3C compliance,
chromedriver will reference the element with a UUID in place of the
existing ID generation method.

Chromedriver wrapping/unwrapping functions have been changed to match
the new referencing when the W3C flag is true.

BUG=
==========

to

==========
[chromedriver] Added option to make element references W3C compliant.

This patch is done on behalf of roisinmcl@chromium.org (original work in
https://codereview.chromium.org/2230053002/).

When a chromedrvier session is created with a flag for W3C compliance,
chromedriver will reference the element with a UUID in place of the
existing ID generation method.

Chromedriver wrapping/unwrapping functions have been changed to match
the new referencing when the W3C flag is true.

BUG=

Committed: https://crrev.com/f2f2146a3f18c7596da37087662f0aeec3b09bfd
Cr-Commit-Position: refs/heads/master@{#434753}
==========

[commit-bot: I haz the power, 2016-11-28 22:52:44]

Patchset 3 (id:??) landed as
https://crrev.com/f2f2146a3f18c7596da37087662f0aeec3b09bfd
Cr-Commit-Position: refs/heads/master@{#434753}