Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc

Issue 2295443003: [chromedriver] Added option to make element references W3C compliant. (Closed)
Patch Set: fix errors introduced during previous rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
diff --git a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
index 5ab7fb1efb0db91c35ad8b3972dbcb7bd3ae58ca..52a931b3d82e9a75f4f729a80bc53b3c8570d6a2 100644
--- a/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
+++ b/chrome/test/chromedriver/chrome/chrome_desktop_impl.cc
@@ -113,7 +113,8 @@ ChromeDesktopImpl::~ChromeDesktopImpl() {
Status ChromeDesktopImpl::WaitForPageToLoad(
const std::string& url,
const base::TimeDelta& timeout_raw,
- std::unique_ptr<WebView>* web_view) {
+ std::unique_ptr<WebView>* web_view,
+ bool w3c_compliant) {
Timeout timeout(timeout_raw);
std::string id;
WebViewInfo::Type type = WebViewInfo::Type::kPage;
@@ -148,7 +149,7 @@ Status ChromeDesktopImpl::WaitForPageToLoad(
device_metrics = nullptr;
}
std::unique_ptr<WebView> web_view_tmp(
- new WebViewImpl(id, devtools_http_client_->browser_info(),
+ new WebViewImpl(id, w3c_compliant, devtools_http_client_->browser_info(),
devtools_http_client_->CreateClient(id), device_metrics,
page_load_strategy()));
Status status = web_view_tmp->ConnectIfNecessary();
@@ -163,14 +164,16 @@ Status ChromeDesktopImpl::WaitForPageToLoad(
}
Status ChromeDesktopImpl::GetAutomationExtension(
- AutomationExtension** extension) {
+ AutomationExtension** extension,
+ bool w3c_compliant) {
if (!automation_extension_) {
std::unique_ptr<WebView> web_view;
Status status = WaitForPageToLoad(
"chrome-extension://aapnijgdinlhnhlmodcfapnahmbfebeb/"
"_generated_background_page.html",
base::TimeDelta::FromSeconds(10),
- &web_view);
+ &web_view,
+ w3c_compliant);
if (status.IsError())
return Status(kUnknownError, "cannot get automation extension", status);
« no previous file with comments | « chrome/test/chromedriver/chrome/chrome_desktop_impl.h ('k') | chrome/test/chromedriver/chrome/chrome_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698