Use ChannelMojo between app shims and the browser process.

Use ChannelMojo between app shims and the browser process.

BUG=604282
Committed: https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f
Cr-Commit-Position: refs/heads/master@{#416514}

[Sam McNally, 2016-08-31 05:27:49]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 05:27:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 07:21:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 07:21:09]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Sam McNally, 2016-08-31 09:17:21]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 09:17:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 09:24:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 09:24:02]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam McNally, 2016-09-01 01:16:45]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 01:17:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-01 01:52:09]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 01:52:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 02:47:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 02:47:29]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-09-01 03:28:12]

Patchset #1 (id:1) has been deleted

[Sam McNally, 2016-09-01 03:28:15]

Patchset #1 (id:20001) has been deleted

[Sam McNally, 2016-09-01 03:28:36]

Patchset #1 (id:40001) has been deleted

[Sam McNally, 2016-09-01 05:26:40]

Patchset #1 (id:60001) has been deleted

[Sam McNally, 2016-09-01 05:36:50]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-09-01 05:36:52]

Patchset #1 (id:80001) has been deleted

[commit-bot: I haz the power, 2016-09-01 05:37:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-09-01 05:39:33]

sammc@chromium.org changed reviewers:
+ dominickn@chromium.org, rockot@chromium.org

[commit-bot: I haz the power, 2016-09-01 06:34:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 06:34:23]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-09-01 23:43:34]

lgtm

https://codereview.chromium.org/2295063002/diff/100001/mojo/edk/system/node_c...
File mojo/edk/system/node_controller.cc (right):

https://codereview.chromium.org/2295063002/diff/100001/mojo/edk/system/node_c...
mojo/edk/system/node_controller.cc:1272: if (name_ != peer_name) {
nit: I was originally a bit confused about why this change was made. Maybe
comment that it's to support in-process use of the peer connection API?

[Sam McNally, 2016-09-02 00:12:53]

Patchset #2 (id:120001) has been deleted

[Sam McNally, 2016-09-02 00:13:05]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[Sam McNally, 2016-09-02 00:13:24]

https://codereview.chromium.org/2295063002/diff/100001/mojo/edk/system/node_c...
File mojo/edk/system/node_controller.cc (right):

https://codereview.chromium.org/2295063002/diff/100001/mojo/edk/system/node_c...
mojo/edk/system/node_controller.cc:1272: if (name_ != peer_name) {
On 2016/09/01 23:43:34, Ken Rockot wrote:
> nit: I was originally a bit confused about why this change was made. Maybe
> comment that it's to support in-process use of the peer connection API?

Done.

[commit-bot: I haz the power, 2016-09-02 00:13:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 01:23:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-02 01:23:35]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-09-05 06:37:53]

lgtm - patched this in on my trashcan and launching an app shim from an
add-to-shelf banner and via add to applications seems to work.

[Sam McNally, 2016-09-05 07:12:46]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2016-09-05 07:12:47]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org
Link to the patchset: https://codereview.chromium.org/2295063002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-09-05 07:12:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-05 08:20:02]

Committed patchset #2 (id:140001)

[commit-bot: I haz the power, 2016-09-05 08:22:07]

Description was changed from

==========
Use ChannelMojo between app shims and the browser process.

BUG=604282
==========

to

==========
Use ChannelMojo between app shims and the browser process.

BUG=604282

Committed: https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f
Cr-Commit-Position: refs/heads/master@{#416514}
==========

[commit-bot: I haz the power, 2016-09-05 08:22:09]

Patchset 2 (id:??) landed as
https://crrev.com/eed8f2761d1e7bbf97ae73daaa348b77ab82600f
Cr-Commit-Position: refs/heads/master@{#416514}