Support creating mojo peer connections from named pipes.

Support creating mojo peer connections from named pipes.

This adds NamedPlatformHandle, which represents a named pipe - a path to
a unix domain socket on POSIX or a pipe name on Windows - and
CreateServerHandle and CreateClientHandle which create server and client
ScopedPlatformHandles, respectively, from a NamedPlatformHandle. This
also changes ChannelPosix to support unconnected server sockets created
by CreateServerHandle.

BUG=604282
Committed: https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3
Cr-Commit-Position: refs/heads/master@{#415560}

[Sam McNally, 2016-08-30 07:24:07]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 07:24:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-08-30 07:25:16]

sammc@chromium.org changed reviewers:
+ rockot@chromium.org

[commit-bot: I haz the power, 2016-08-30 08:57:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 08:57:45]

Dry run: This issue passed the CQ dry run.

[Ken Rockot(use gerrit already), 2016-08-30 16:58:32]

Nice. Only one comment, but I think it's blocking.

A cheesy, intermediate (but probably acceptable) solution could be to add a new
source_set target just for this file and have the EDK depend on that. I'd
*really* rather just move it to base or duplicate it though.

https://codereview.chromium.org/2282413004/diff/1/mojo/edk/embedder/BUILD.gn
File mojo/edk/embedder/BUILD.gn (right):

https://codereview.chromium.org/2282413004/diff/1/mojo/edk/embedder/BUILD.gn#...
mojo/edk/embedder/BUILD.gn:115: deps += [ "//ipc" ]
I'd sooner duplicate the code or try to move it into base before adding an EDK
dependency on //ipc. Can we please try to avoid this?

[Sam McNally, 2016-08-30 23:49:20]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 23:50:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-08-30 23:52:16]

Patchset #2 (id:20001) has been deleted

[Sam McNally, 2016-08-30 23:58:43]

The CQ bit was checked by sammc@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 23:59:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-08-30 23:59:31]

Patchset #2 (id:40001) has been deleted

[Sam McNally, 2016-08-31 00:00:13]

https://codereview.chromium.org/2282413004/diff/1/mojo/edk/embedder/BUILD.gn
File mojo/edk/embedder/BUILD.gn (right):

https://codereview.chromium.org/2282413004/diff/1/mojo/edk/embedder/BUILD.gn#...
mojo/edk/embedder/BUILD.gn:115: deps += [ "//ipc" ]
On 2016/08/30 16:58:31, Ken Rockot wrote:
> I'd sooner duplicate the code or try to move it into base before adding an EDK
> dependency on //ipc. Can we please try to avoid this?

Done.

[Ken Rockot(use gerrit already), 2016-08-31 00:31:14]

lgtm

[commit-bot: I haz the power, 2016-08-31 02:46:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 02:46:57]

Dry run: This issue passed the CQ dry run.

[Sam McNally, 2016-08-31 03:45:48]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2016-08-31 03:45:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 04:33:42]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-08-31 04:36:08]

Description was changed from

==========
Support creating mojo peer connections from named pipes.

This adds NamedPlatformHandle, which represents a named pipe - a path to
a unix domain socket on POSIX or a pipe name on Windows - and
CreateServerHandle and CreateClientHandle which create server and client
ScopedPlatformHandles, respectively, from a NamedPlatformHandle. This
also changes ChannelPosix to support unconnected server sockets created
by CreateServerHandle.

BUG=604282
==========

to

==========
Support creating mojo peer connections from named pipes.

This adds NamedPlatformHandle, which represents a named pipe - a path to
a unix domain socket on POSIX or a pipe name on Windows - and
CreateServerHandle and CreateClientHandle which create server and client
ScopedPlatformHandles, respectively, from a NamedPlatformHandle. This
also changes ChannelPosix to support unconnected server sockets created
by CreateServerHandle.

BUG=604282

Committed: https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3
Cr-Commit-Position: refs/heads/master@{#415560}
==========

[commit-bot: I haz the power, 2016-08-31 04:36:10]

Patchset 2 (id:??) landed as
https://crrev.com/41729472e843a5cd78c32dba6d6ba3a24ef8e7f3
Cr-Commit-Position: refs/heads/master@{#415560}