Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/usb/web_usb_detector_unittest.cc

Issue 2295023002: Delay WebUSB initialization until after browser startup. (Closed)
Patch Set: Add UMA for WebUSB detector initialization time. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/usb/web_usb_detector.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/usb/web_usb_detector_unittest.cc
diff --git a/chrome/browser/usb/web_usb_detector_unittest.cc b/chrome/browser/usb/web_usb_detector_unittest.cc
index cc7cc1b8d78750ebdff6724268d2a4bab0e338d4..f64661e501cda3670c89c3a93ef65f92610ed190 100644
--- a/chrome/browser/usb/web_usb_detector_unittest.cc
+++ b/chrome/browser/usb/web_usb_detector_unittest.cc
@@ -60,6 +60,7 @@ TEST_F(WebUsbDetectorTest, UsbDeviceAddedAndRemoved) {
std::string guid = device->guid();
WebUsbDetector web_usb_detector;
+ web_usb_detector.Initialize();
device_client_.usb_service()->AddDevice(device);
message_center::Notification* notification =
@@ -87,6 +88,7 @@ TEST_F(WebUsbDetectorTest, UsbDeviceWithoutProductNameAddedAndRemoved) {
std::string guid = device->guid();
WebUsbDetector web_usb_detector;
+ web_usb_detector.Initialize();
device_client_.usb_service()->AddDevice(device);
// For device without product name, no notification is generated.
@@ -103,6 +105,7 @@ TEST_F(WebUsbDetectorTest, UsbDeviceWithoutLandingPageAddedAndRemoved) {
std::string guid = device->guid();
WebUsbDetector web_usb_detector;
+ web_usb_detector.Initialize();
device_client_.usb_service()->AddDevice(device);
// For device without landing page, no notification is generated.
@@ -123,6 +126,7 @@ TEST_F(WebUsbDetectorTest, UsbDeviceWasThereBeforeAndThenRemoved) {
EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid));
WebUsbDetector web_usb_detector;
+ web_usb_detector.Initialize();
device_client_.usb_service()->RemoveDevice(device);
EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid));
@@ -166,6 +170,7 @@ TEST_F(
EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
WebUsbDetector web_usb_detector;
+ web_usb_detector.Initialize();
}
TEST_F(
@@ -198,6 +203,7 @@ TEST_F(
EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
WebUsbDetector web_usb_detector;
+ web_usb_detector.Initialize();
device_client_.usb_service()->RemoveDevice(device_1);
EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_1));
@@ -234,6 +240,7 @@ TEST_F(WebUsbDetectorTest,
EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_3));
WebUsbDetector web_usb_detector;
+ web_usb_detector.Initialize();
device_client_.usb_service()->RemoveDevice(device_1);
EXPECT_EQ(nullptr, message_center_->FindVisibleNotificationById(guid_1));
@@ -277,6 +284,7 @@ TEST_F(WebUsbDetectorTest, ThreeUsbDevicesAddedAndRemoved) {
std::string guid_3 = device_3->guid();
WebUsbDetector web_usb_detector;
+ web_usb_detector.Initialize();
device_client_.usb_service()->AddDevice(device_1);
message_center::Notification* notification_1 =
@@ -344,6 +352,7 @@ TEST_F(WebUsbDetectorTest, ThreeUsbDeviceAddedAndRemovedDifferentOrder) {
std::string guid_3 = device_3->guid();
WebUsbDetector web_usb_detector;
+ web_usb_detector.Initialize();
device_client_.usb_service()->AddDevice(device_1);
message_center::Notification* notification_1 =
« no previous file with comments | « chrome/browser/usb/web_usb_detector.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698