Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4314)

Unified Diff: build/android/adb_chrome_public_command_line

Issue 2294973003: adb_chrome_public_command_line should write to old and new paths (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/adb_chrome_public_command_line
diff --git a/build/android/adb_chrome_public_command_line b/build/android/adb_chrome_public_command_line
index ac379e8f7852f53c0c366b158b353deaba5f49c0..913c21b956aaca395a189097c29e89923e3774a1 100755
--- a/build/android/adb_chrome_public_command_line
+++ b/build/android/adb_chrome_public_command_line
@@ -13,5 +13,11 @@
# To remove all Chrome flags, pass an empty string for the flags:
# adb_chrome_public_command_line ""
+# The command line arguments file is transitioning from
+# /data/local/chrome-command-line to /data/local/tmp/chrome-command-line
+# (https://crbug.com/593720). To support both old and new builds of
+# Chrome, we currently write the same flags to both places.
+$(dirname $0)/adb_command_line.py --device-path \
jbudorick 2016/08/31 15:10:23 Should this be exec $(dirname $0)/adb_command_line
johnme 2016/08/31 17:41:46 No, exec is an optimisation that causes bash to st
jbudorick 2016/09/03 00:33:55 I'm betraying my limited knowledge of bash, it see
+ /data/local/tmp/chrome-command-line "$@" &&
exec $(dirname $0)/adb_command_line.py --device-path \
/data/local/chrome-command-line "$@"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698