build/android/adb_chrome_public_command_line - Issue 2294973003: adb_chrome_public_command_line should write to old and new paths

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: build/android/adb_chrome_public_command_line

Issue 2294973003: adb_chrome_public_command_line should write to old and new paths (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 #!/bin/bash	1 #!/bin/bash

2 #	2 #

3 # Copyright 2015 The Chromium Authors. All rights reserved.	3 # Copyright 2015 The Chromium Authors. All rights reserved.

4 # Use of this source code is governed by a BSD-style license that can be	4 # Use of this source code is governed by a BSD-style license that can be

5 # found in the LICENSE file.	5 # found in the LICENSE file.

6	6

7 # If no flags are given, prints the current Chrome flags.	7 # If no flags are given, prints the current Chrome flags.

8 #	8 #

9 # Otherwise, the given flags are used to REPLACE (not modify) the Chrome	9 # Otherwise, the given flags are used to REPLACE (not modify) the Chrome

10 # flags. For example:	10 # flags. For example:

11 # adb_chrome_public_command_line --enable-webgl	11 # adb_chrome_public_command_line --enable-webgl

12 #	12 #

13 # To remove all Chrome flags, pass an empty string for the flags:	13 # To remove all Chrome flags, pass an empty string for the flags:

14 # adb_chrome_public_command_line ""	14 # adb_chrome_public_command_line ""

15	15

	16 # The command line arguments file is transitioning from

	17 # /data/local/chrome-command-line to /data/local/tmp/chrome-command-line

	18 # (https://crbug.com/593720). To support both old and new builds of

	19 # Chrome, we currently write the same flags to both places.

	20 $(dirname $0)/adb_command_line.py --device-path \
	jbudorick 2016/08/31 15:10:23 Should this be exec $(dirname $0)/adb_command_line Should this be exec $(dirname $0)/adb_command_line.py like the line below? johnme 2016/08/31 17:41:46 No, exec is an optimisation that causes bash to st Show quoted text On 2016/08/31 15:10:23, jbudorick wrote: > Should this be exec $(dirname $0)/adb_command_line.py like the line below? No, exec is an optimisation that causes bash to stop executing the current script and replace its process with the process being run (instead of forking). So if we exec here, we'll never run the line below. jbudorick 2016/09/03 00:33:55 I'm betraying my limited knowledge of bash, it see Show quoted text On 2016/08/31 17:41:46, johnme wrote: > On 2016/08/31 15:10:23, jbudorick wrote: > > Should this be exec $(dirname $0)/adb_command_line.py like the line below? > > No, exec is an optimisation that causes bash to stop executing the current > script and replace its process with the process being run (instead of forking). > So if we exec here, we'll never run the line below. I'm betraying my limited knowledge of bash, it seems. sgtm.
	21 /data/local/tmp/chrome-command-line "$@" &&

16 exec $(dirname $0)/adb_command_line.py --device-path \	22 exec $(dirname $0)/adb_command_line.py --device-path \

17 /data/local/chrome-command-line "$@"	23 /data/local/chrome-command-line "$@"

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »