Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 2294903002: Revert "Rework default GN symbol handling for win goma builds." (Closed)

Created:
4 years, 3 months ago by mmenke
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Rework default GN symbol handling for win goma builds." This reverts commit 64fea5e29655036e2c5410b903cd43f832d04e93. The CL broke the Windows build for some users. NOPRESUBMIT=true NOTRY=true TBR=dpranke@chromium.org BUG=634184 Committed: https://crrev.com/67a9b0799014469e2819b237c398f7e0ab0425f6 Cr-Commit-Position: refs/heads/master@{#415361}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M build/config/compiler/BUILD.gn View 1 chunk +8 lines, -2 lines 0 comments Download
M build/config/compiler/compiler.gni View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294903002/1
4 years, 3 months ago (2016-08-30 18:23:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 18:24:56 UTC) #10
mmenke
Already in the queue.
4 years, 3 months ago (2016-08-30 18:25:07 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 18:26:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/67a9b0799014469e2819b237c398f7e0ab0425f6
Cr-Commit-Position: refs/heads/master@{#415361}

Powered by Google App Engine
This is Rietveld 408576698