Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 2294903002: Revert "Rework default GN symbol handling for win goma builds." (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 import("//build/config/compiler/compiler.gni") 7 import("//build/config/compiler/compiler.gni")
8 import("//build/config/nacl/config.gni") 8 import("//build/config/nacl/config.gni")
9 import("//build/toolchain/cc_wrapper.gni") 9 import("//build/toolchain/cc_wrapper.gni")
10 import("//build/toolchain/toolchain.gni") 10 import("//build/toolchain/toolchain.gni")
(...skipping 1487 matching lines...) Expand 10 before | Expand all | Expand 10 after
1498 # You can override the symbol level on a per-target basis by removing the 1498 # You can override the symbol level on a per-target basis by removing the
1499 # default config and then adding the named one you want: 1499 # default config and then adding the named one you want:
1500 # 1500 #
1501 # configs -= [ "//build/config/compiler:default_symbols" ] 1501 # configs -= [ "//build/config/compiler:default_symbols" ]
1502 # configs += [ "//build/config/compiler:symbols" ] 1502 # configs += [ "//build/config/compiler:symbols" ]
1503 1503
1504 # Full symbols. 1504 # Full symbols.
1505 config("symbols") { 1505 config("symbols") {
1506 if (is_win) { 1506 if (is_win) {
1507 import("//build/toolchain/goma.gni") 1507 import("//build/toolchain/goma.gni")
1508 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue. 1508 if (use_goma) {
1509 1509 # Disable symbols during goma compilation because otherwise the redundant
1510 # debug information (repeated in every .obj file) makes linker memory
1511 # consumption and link times unsustainable (crbug.com/630074).
1512 cflags = []
1513 } else {
1514 cflags = [ "/Zi" ] # Produce PDB file, no edit and continue.
1515 }
1510 if (is_win_fastlink && visual_studio_version != "2013") { 1516 if (is_win_fastlink && visual_studio_version != "2013") {
1511 # Tell VS 2015+ to create a PDB that references debug 1517 # Tell VS 2015+ to create a PDB that references debug
1512 # information in .obj and .lib files instead of copying 1518 # information in .obj and .lib files instead of copying
1513 # it all. This flag is incompatible with /PROFILE 1519 # it all. This flag is incompatible with /PROFILE
1514 ldflags = [ "/DEBUG:FASTLINK" ] 1520 ldflags = [ "/DEBUG:FASTLINK" ]
1515 } else { 1521 } else {
1516 ldflags = [ "/DEBUG" ] 1522 ldflags = [ "/DEBUG" ]
1517 } 1523 }
1518 } else { 1524 } else {
1519 if (is_mac || is_ios) { 1525 if (is_mac || is_ios) {
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
1583 1589
1584 if (is_ios || is_mac) { 1590 if (is_ios || is_mac) {
1585 # On Mac and iOS, this enables support for ARC (automatic ref-counting). 1591 # On Mac and iOS, this enables support for ARC (automatic ref-counting).
1586 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html. 1592 # See http://clang.llvm.org/docs/AutomaticReferenceCounting.html.
1587 config("enable_arc") { 1593 config("enable_arc") {
1588 common_flags = [ "-fobjc-arc" ] 1594 common_flags = [ "-fobjc-arc" ]
1589 cflags_objc = common_flags 1595 cflags_objc = common_flags
1590 cflags_objcc = common_flags 1596 cflags_objcc = common_flags
1591 } 1597 }
1592 } 1598 }
OLDNEW
« no previous file with comments | « no previous file | build/config/compiler/compiler.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698