Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2294883007: Reland of Fragment blocks with non-visible overflow as normally when printing. (Closed)

Created:
4 years, 3 months ago by paulmeyer
Modified:
4 years, 3 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Fragment blocks with non-visible overflow as normally when printing. (patchset #1 id:1 of https://codereview.chromium.org/2300763002/ ) Reason for revert: The reverted CL seems not to have been the problem. Original issue's description: > Revert of Fragment blocks with non-visible overflow as normally when printing. (patchset #1 id:1 of https://codereview.chromium.org/2298193002/ ) > > Reason for revert: > Suspected cause of "virtual/threaded/fast/scroll-behavior/smooth-scroll/main-thread-scrolling-reason-correctness.html" failures in webkit_tests on "WebKit Linux (dbg)" bot. > > example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28dbg%29/builds/9099 > > Original issue's description: > > Fragment blocks with non-visible overflow as normally when printing. > > > > Splitting scrollbars into multiple fragmentainers is only problematic in > > interactive media. We don't need to impose any such pagination restrictions > > when printing, since printing is non-interactive, > > > > BUG=641983 > > > > Committed: https://crrev.com/53d4d7aff8e25eae2ece5bbf5a53eec940871fa8 > > Cr-Commit-Position: refs/heads/master@{#415645} > > TBR=eae@chromium.org,mstensho@opera.com > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=641983 > > Committed: https://crrev.com/0928918d8e570a7367a571d158a34933077e7022 > Cr-Commit-Position: refs/heads/master@{#415712} TBR=eae@chromium.org,mstensho@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=641983 Committed: https://crrev.com/054e1dec56f7a7a76f64adc9b3a27c94d0778e33 Cr-Commit-Position: refs/heads/master@{#416058}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/printing/overflow-auto.html View 1 chunk +29 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/printing/overflow-auto-expected.html View 1 chunk +29 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
paulmeyer
Created Reland of Fragment blocks with non-visible overflow as normally when printing.
4 years, 3 months ago (2016-09-01 19:49:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294883007/1
4 years, 3 months ago (2016-09-01 19:50:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-01 21:24:14 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/054e1dec56f7a7a76f64adc9b3a27c94d0778e33 Cr-Commit-Position: refs/heads/master@{#416058}
4 years, 3 months ago (2016-09-01 21:26:38 UTC) #6
eae
4 years, 3 months ago (2016-09-05 20:35:54 UTC) #7
Message was sent while issue was closed.
RS LGTM

Powered by Google App Engine
This is Rietveld 408576698