Issue 2294883004: Don't return negative token positions in stack traces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2294883004: Don't return negative token positions in stack traces. (Closed)

Created:
4 years, 3 months ago by turnidge

Modified:
4 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org, devoncarew

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+58 lines, -1 line)			Patch
A	runtime/observatory/tests/service/positive_token_pos_test.dart	View	1 chunk	+48 lines, -0 lines	0 comments	Download
M	runtime/observatory/tests/service/service_test_common.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/debugger.cc	View	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 5 (2 generated)

turnidge

4 years, 3 months ago (2016-08-31 23:22:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cd8292d1754fd3a0b03e18a8f9c7a0cdc9332909 (presubmit successful).