Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: runtime/observatory/tests/service/service_test_common.dart

Issue 2294883004: Don't return negative token positions in stack traces. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/tests/service/positive_token_pos_test.dart ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/service_test_common.dart
diff --git a/runtime/observatory/tests/service/service_test_common.dart b/runtime/observatory/tests/service/service_test_common.dart
index 4a42290543cc00e9d231d212d3e0e76de7dc30b0..3373fa4434b1ae4a5007d96648a099456092a09d 100644
--- a/runtime/observatory/tests/service/service_test_common.dart
+++ b/runtime/observatory/tests/service/service_test_common.dart
@@ -233,6 +233,11 @@ Future<Isolate> stepOver(Isolate isolate) async {
return hasStoppedAtBreakpoint(isolate);
}
+Future<Isolate> stepInto(Isolate isolate) async {
+ await isolate.stepInto();
+ return hasStoppedAtBreakpoint(isolate);
+}
+
Future<Class> getClassFromRootLib(Isolate isolate, String className) async {
Library rootLib = await isolate.rootLibrary.load();
for (var i = 0; i < rootLib.classes.length; i++) {
« no previous file with comments | « runtime/observatory/tests/service/positive_token_pos_test.dart ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698