Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: build/config/android/config.gni

Issue 2294823002: Remove lint variables from SDK version and path. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/config.gni
diff --git a/build/config/android/config.gni b/build/config/android/config.gni
index b658069a34895f6c3b316f17c5c268c0cb44fa29..daf8a705b3f56d41954ed6a45427547257258a09 100644
--- a/build/config/android/config.gni
+++ b/build/config/android/config.gni
@@ -39,10 +39,8 @@ if (is_android) {
lint_android_sdk_version = "23"
if (!defined(default_android_sdk_root)) {
- # Reuse the lint variables to ensure that the lint version gets updated
- # when the upstream SDK version is updated.
- default_android_sdk_root = lint_android_sdk_root
- default_android_sdk_version = lint_android_sdk_version
+ default_android_sdk_root = "//third_party/android_tools/sdk"
jbudorick 2016/08/30 15:49:10 This seems odd too. Why are lint_android_sdk_root
estevenson 2016/08/30 16:43:51 Because the defaults below can be set in other pla
jbudorick 2016/08/31 18:53:19 I think I'd prefer a downstream change. Having a h
estevenson 2016/08/31 20:41:01 Done.
+ default_android_sdk_version = "23"
default_android_sdk_build_tools_version = "23.0.1"
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698