Remove lint variables from SDK version and path.

build/config/android/config.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # This file contains common system config stuff for the Android build.
 
 if (is_android) {
   assert(rebase_path("//", root_build_dir) == "../../",
          "Android output directory must be nested 2 levels within src/ (" +
              "e.g.: out-gn/Debug). http://crbug.com/412935")
@@ skipping 21 matching lines @@
     assert(defined(default_android_ndk_version))
   }
 
   # The same version of lint should be used for building all targets,
   # and these args ensure that the upstream version of lint is used for
   # both upstream and downstream targets.
   lint_android_sdk_root = "//third_party/android_tools/sdk"
   lint_android_sdk_version = "23"
 
   if (!defined(default_android_sdk_root)) {
-    # Reuse the lint variables to ensure that the lint version gets updated
-    # when the upstream SDK version is updated.
-    default_android_sdk_root = lint_android_sdk_root
-    default_android_sdk_version = lint_android_sdk_version
+    default_android_sdk_root = "//third_party/android_tools/sdk"

[jbudorick, 2016/08/30 15:49:10]

This seems odd too. Why are lint_android_sdk_root and _version separate from the
android_sdk_root and _version that are configurable below?

[estevenson, 2016/08/30 16:43:51]

Because the defaults below can be set in other places and might not be
"//third_party/android_tools/sdk". I hardcoded it here instead so that we don't
need to make an additional downstream change. If you'd prefer, I can make the
downstream change and use the same pattern for defaults in this file.

[jbudorick, 2016/08/31 18:53:19]

I think I'd prefer a downstream change. Having a hard-coded lint path doesn't
seem like the right default behavior to me.

[estevenson, 2016/08/31 20:41:01]

Done.

+    default_android_sdk_version = "23"
     default_android_sdk_build_tools_version = "23.0.1"
   }
 
   if (!defined(default_android_keystore_path)) {
     default_android_keystore_path =
         "//build/android/ant/chromium-debug.keystore"
     default_android_keystore_name = "chromiumdebugkey"
     default_android_keystore_password = "chromium"
   }
 
@@ skipping 266 matching lines @@
           "//build/toolchain/android:${android_secondary_abi_cpu}"
     }
   }
 }
 
 declare_args() {
   # Enables used resource whitelist generation. Set for official builds only
   # as a large amount of build output is generated.
   enable_resource_whitelist_generation = is_android && is_official_build
 }