Set log level to logging::LOG_FATAL for edid_parser_fuzzer.

Set log level to logging::LOG_FATAL for edid_parser_fuzzer.

TBR=aizatsky@chromium.org, inferno@chromium.org, oshima@chromium.org, robert.bradford@intel.com
BUG=584819
Committed: https://crrev.com/84a3d0c455b12784c1fdee6dc8a3312380c9675c
Cr-Commit-Position: refs/heads/master@{#415282}

[mmoroz, 2016-08-30 11:00:12]

On 2016/08/30 10:58:58, mmoroz wrote:

The fuzzer is completely broken due to its excessive logging. I'll try to TBR,
since CL is pretty simple and I want to get the fuzzer back to work ASAP.

[mmoroz, 2016-08-30 11:00:21]

Description was changed from

==========
Set log level to logging::LOG_FATAL for edid_parser_fuzzer.

R=aizatsky@chromium.org, inferno@chromium.org, oshima@chromium.org,
robert.bradford@intel.com
BUG=584819
==========

to

==========
Set log level to logging::LOG_FATAL for edid_parser_fuzzer.

TBR=aizatsky@chromium.org, inferno@chromium.org, oshima@chromium.org,
robert.bradford@intel.com
BUG=584819
==========

[mmoroz, 2016-08-30 11:00:26]

The CQ bit was checked by mmoroz@chromium.org

[commit-bot: I haz the power, 2016-08-30 11:00:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[robert.bradford, 2016-08-30 11:03:53]

https://codereview.chromium.org/2294733002/diff/1/ui/display/util/edid_parser...
File ui/display/util/edid_parser_fuzzer.cc (right):

https://codereview.chromium.org/2294733002/diff/1/ui/display/util/edid_parser...
ui/display/util/edid_parser_fuzzer.cc:15:
logging::SetMinLogLevel(logging::LOG_FATAL);
I didn't know you could do that - very ingenious. non-OWNER lgtm.

[commit-bot: I haz the power, 2016-08-30 11:29:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 11:29:50]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmoroz, 2016-08-30 11:46:04]

On 2016/08/30 11:29:50, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

Linking issue with debug build:

[2431/8458] LINK ./edid_parser_fuzzer
FAILED: edid_parser_fuzzer 
../../third_party/llvm-build/Release+Asserts/bin/clang++ -Wl,--fatal-warnings
-fPIC -Wl,-z,noexecstack -Wl,-z,now -Wl,-z,relro -Wl,-z,defs -fuse-ld=gold
-B../../third_party/binutils/Linux_x64/Release/bin -Wl,--threads
-Wl,--thread-count=4 -Wl,--icf=all -pthread -m64
--sysroot=../../build/linux/debian_wheezy_amd64-sysroot
-L/b/c/b/linux/src/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu
-Wl,-rpath-link=/b/c/b/linux/src/build/linux/debian_wheezy_amd64-sysroot/lib/x86_64-linux-gnu
-L/b/c/b/linux/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu
-Wl,-rpath-link=/b/c/b/linux/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/x86_64-linux-gnu
-L/b/c/b/linux/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
-Wl,-rpath-link=/b/c/b/linux/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib/gcc/x86_64-linux-gnu/4.6
-L/b/c/b/linux/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib
-Wl,-rpath-link=/b/c/b/linux/src/build/linux/debian_wheezy_amd64-sysroot/usr/lib
-Wl,-rpath-link=../Debug -Wl,--disable-new-dtags -Wl,-rpath=\$ORIGIN/.
-Wl,-rpath-link=. -Wl,--export-dynamic -o "./edid_parser_fuzzer"
-Wl,--start-group @"./edid_parser_fuzzer.rsp" ./libdisplay_util.so
./libgeometry.so -Wl,--end-group  -ldl -lrt -lgmodule-2.0 -lgobject-2.0
-lgthread-2.0 -lglib-2.0 
../../ui/display/util/edid_parser_fuzzer.cc:15: error: undefined reference to
'logging::SetMinLogLevel(int)'
clang: error: linker command failed with exit code 1 (use -v to see invocation)




Need to add "//base" to deps.

[mmoroz, 2016-08-30 11:47:33]

The CQ bit was checked by mmoroz@chromium.org

[mmoroz, 2016-08-30 11:47:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
robert.bradford@intel.com
Link to the patchset: https://codereview.chromium.org/2294733002/#ps20001
(title: "Add "//base" to deps to avoid linker failure on debug build.")

[commit-bot: I haz the power, 2016-08-30 11:47:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 12:27:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:27:32]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmoroz, 2016-08-30 12:45:59]

The CQ bit was checked by mmoroz@chromium.org

[commit-bot: I haz the power, 2016-08-30 12:46:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 13:22:52]

Description was changed from

==========
Set log level to logging::LOG_FATAL for edid_parser_fuzzer.

TBR=aizatsky@chromium.org, inferno@chromium.org, oshima@chromium.org,
robert.bradford@intel.com
BUG=584819
==========

to

==========
Set log level to logging::LOG_FATAL for edid_parser_fuzzer.

TBR=aizatsky@chromium.org, inferno@chromium.org, oshima@chromium.org,
robert.bradford@intel.com
BUG=584819
==========

[commit-bot: I haz the power, 2016-08-30 13:22:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-08-30 13:24:52]

Description was changed from

==========
Set log level to logging::LOG_FATAL for edid_parser_fuzzer.

TBR=aizatsky@chromium.org, inferno@chromium.org, oshima@chromium.org,
robert.bradford@intel.com
BUG=584819
==========

to

==========
Set log level to logging::LOG_FATAL for edid_parser_fuzzer.

TBR=aizatsky@chromium.org, inferno@chromium.org, oshima@chromium.org,
robert.bradford@intel.com
BUG=584819

Committed: https://crrev.com/84a3d0c455b12784c1fdee6dc8a3312380c9675c
Cr-Commit-Position: refs/heads/master@{#415282}
==========

[commit-bot: I haz the power, 2016-08-30 13:24:53]

Patchset 2 (id:??) landed as
https://crrev.com/84a3d0c455b12784c1fdee6dc8a3312380c9675c
Cr-Commit-Position: refs/heads/master@{#415282}

[inferno, 2016-08-30 14:13:24]

lgtm,

a lot of fuzzers seem to be needing this. we should look for a generic
workaround for libfuzzer.

[kcc2, 2016-08-30 16:11:46]

On 2016/08/30 14:13:24, inferno wrote:
> lgtm,
> 
> a lot of fuzzers seem to be needing this. we should look for a generic
> workaround for libfuzzer.

libFuzzer has -close_fd_mask=3, which will close stdin & stderr.
However, I still think that it's better to modify the targets to not use
logging.