Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: chrome/browser/extensions/extension_service.cc

Issue 2294653002: Some linked_ptr -> unique_ptr conversion in extensions/browser. (Closed)
Patch Set: nullptr Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_service.cc
diff --git a/chrome/browser/extensions/extension_service.cc b/chrome/browser/extensions/extension_service.cc
index 9f425f57445b17dc110c3530babf849ffaea4c11..819d88bb7f4fde70923d947070f3282065970692 100644
--- a/chrome/browser/extensions/extension_service.cc
+++ b/chrome/browser/extensions/extension_service.cc
@@ -176,8 +176,7 @@ void ExtensionService::ClearProvidersForTesting() {
void ExtensionService::AddProviderForTesting(
ExternalProviderInterface* test_provider) {
Devlin 2016/08/30 19:21:53 Can we add a TODO to make this take a unique_ptr (
lazyboy 2016/08/30 20:30:56 Done. Changed those places. I also tried changing
Devlin 2016/08/30 22:48:28 Ack; no need to change it in this CL.
CHECK(test_provider);
- external_extension_providers_.push_back(
- linked_ptr<ExternalProviderInterface>(test_provider));
+ external_extension_providers_.push_back(base::WrapUnique(test_provider));
}
void ExtensionService::BlacklistExtensionForTest(

Powered by Google App Engine
This is Rietveld 408576698