Some linked_ptr -> unique_ptr conversion in extensions/browser.

chrome/browser/extensions/extension_service.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_service.h"
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <iterator>
@@ skipping 156 matching lines @@
 void ExtensionService::SetFileTaskRunnerForTesting(
     const scoped_refptr<base::SequencedTaskRunner>& task_runner) {
   file_task_runner_ = task_runner;
 }
 
 void ExtensionService::ClearProvidersForTesting() {
   external_extension_providers_.clear();
 }
 
 void ExtensionService::AddProviderForTesting(
     ExternalProviderInterface* test_provider) {

[Devlin, 2016/08/30 19:21:53]

Can we add a TODO to make this take a unique_ptr (or, it looks like it's only
called in three places, if you wanted to do it in this cl)?

[lazyboy, 2016/08/30 20:30:56]

Done.
Changed those places.

I also tried changing AddMockExternalProvider's signature to take unique_ptr in
extensoin_service_unittest.cc, gave up as I thought changing that to just wrap a
raw ptr with WrapUnique isn't doing much. The pattern currently looks like:

MockExtensionProvider* provider = new ..;
AddMockExternalProvider(provider);
..
keep accessing |provider| raw ptr.

[Devlin, 2016/08/30 22:48:28]

Ack; no need to change it in this CL.

   CHECK(test_provider);
-  external_extension_providers_.push_back(
-      linked_ptr<ExternalProviderInterface>(test_provider));
+  external_extension_providers_.push_back(base::WrapUnique(test_provider));
 }
 
 void ExtensionService::BlacklistExtensionForTest(
     const std::string& extension_id) {
   ExtensionIdSet blacklisted;
   ExtensionIdSet unchanged;
   blacklisted.insert(extension_id);
   UpdateBlacklistedExtensions(blacklisted, unchanged);
 }
 
@@ skipping 2253 matching lines @@
 }
 
 void ExtensionService::OnProfileDestructionStarted() {
   ExtensionIdSet ids_to_unload = registry_->enabled_extensions().GetIDs();
   for (ExtensionIdSet::iterator it = ids_to_unload.begin();
        it != ids_to_unload.end();
        ++it) {
     UnloadExtension(*it, UnloadedExtensionInfo::REASON_PROFILE_SHUTDOWN);
   }
 }