Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2294473002: Converted Observatory object-view element (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -55 lines) Patch
M runtime/observatory/lib/elements.dart View 4 chunks +3 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/models.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/repositories.dart View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 2 chunks +13 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/context_view.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/object_view.dart View 1 chunk +130 lines, -11 lines 0 comments Download
D runtime/observatory/lib/src/elements/object_view.html View 1 chunk +0 lines, -25 lines 0 comments Download
M runtime/observatory/lib/src/elements/service_view.dart View 1 chunk +0 lines, -9 lines 0 comments Download
A + runtime/observatory/lib/src/models/repositories/object.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + runtime/observatory/lib/src/repositories/object.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 3 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
cbernaschina
4 years, 3 months ago (2016-08-29 18:18:47 UTC) #2
rmacnak
lgtm
4 years, 3 months ago (2016-08-30 20:29:02 UTC) #3
cbernaschina
4 years, 3 months ago (2016-08-30 20:39:19 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
0083d2610e120171c3fcbe7f063fbf71bf05c3b8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698