Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: runtime/observatory/lib/src/app/page.dart

Issue 2294473002: Converted Observatory object-view element (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/context_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/page.dart
diff --git a/runtime/observatory/lib/src/app/page.dart b/runtime/observatory/lib/src/app/page.dart
index 4b2b356e1f209ae3e421641f0d40f10f8af018d6..0f3ce4afeae1b10eab865050532005718ebd3468 100644
--- a/runtime/observatory/lib/src/app/page.dart
+++ b/runtime/observatory/lib/src/app/page.dart
@@ -23,6 +23,7 @@ ObjectPoolRepository _objectPoolRepository
= new ObjectPoolRepository();
ObjectStoreRepository _objectstoreRepository
= new ObjectStoreRepository();
+ObjectRepository _objectRepository = new ObjectRepository();
PersistentHandlesRepository _persistentHandlesRepository
= new PersistentHandlesRepository();
PortsRepository _portsRepository = new PortsRepository();
@@ -261,6 +262,18 @@ class InspectPage extends MatchingPage {
_instanceRepository,
queue: app.queue)
];
+ } else if (obj.kind == 'Object') {
+ container.children = [
+ new ObjectViewElement(app.vm, obj.isolate, obj, app.events,
+ app.notifications,
+ _objectRepository,
+ _retainedSizeRepository,
+ _reachableSizeRepository,
+ _inboundReferencesRepository,
+ _retainingPathRepository,
+ _instanceRepository,
+ queue: app.queue)
+ ];
} else {
ServiceObjectViewElement serviceElement =new Element.tag('service-view');
serviceElement.object = obj;
« no previous file with comments | « runtime/observatory/lib/repositories.dart ('k') | runtime/observatory/lib/src/elements/context_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698