Use unsigned page indexes in CPDF_HintTables.

Use unsigned page indexes in CPDF_HintTables.

Fix up callers from CPDF_DataAvail.

Committed: https://pdfium.googlesource.com/pdfium/+/e0cb687c71d555b55cc30ec59c9b338a0e83f77f

[Lei Zhang, 2016-09-01 01:09:16]

Patchset #1 (id:1) has been deleted

[Lei Zhang, 2016-09-01 01:09:21]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 01:09:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 01:21:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 01:22:00]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-01 01:29:31]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org

[Tom Sepez, 2016-09-01 16:16:27]

https://codereview.chromium.org/2294383003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp (right):

https://codereview.chromium.org/2294383003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:1425: int32_t iPage =
safePage.ValueOrDie();
return false instead of segv? (several places).

https://codereview.chromium.org/2294383003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (right):

https://codereview.chromium.org/2294383003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:368: if (nFirstPageNum < 0)
Do we just want to use base's checked cast magin instead of the < 0 tests?

[Lei Zhang, 2016-09-01 17:58:09]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-01 17:58:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-09-01 17:58:22]

https://codereview.chromium.org/2294383003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp (right):

https://codereview.chromium.org/2294383003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_data_avail.cpp:1425: int32_t iPage =
safePage.ValueOrDie();
On 2016/09/01 16:16:27, Tom Sepez wrote:
> return false instead of segv? (several places).

I was trying to handle them, but I figured they are all protected methods deeper
inside CPDF_DataAvail, so:

- nobody is calling them directly
- the callers to these protected methods all originally received a non-negative
int32_t, thus the value should fit in an int32_t again and they should not fail.
Too fragile of an assumption?

https://codereview.chromium.org/2294383003/diff/20001/core/fpdfapi/fpdf_parse...
File core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp (right):

https://codereview.chromium.org/2294383003/diff/20001/core/fpdfapi/fpdf_parse...
core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp:368: if (nFirstPageNum < 0)
On 2016/09/01 16:16:27, Tom Sepez wrote:
> Do we just want to use base's checked cast magin instead of the < 0 tests?

Done.

[Tom Sepez, 2016-09-01 18:01:16]

lgtm

[commit-bot: I haz the power, 2016-09-01 18:55:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 18:55:43]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-01 20:40:49]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-09-01 20:40:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 20:41:13]

Description was changed from

==========
Use unsigned page indexes in CPDF_HintTables.

Fix up callers from CPDF_DataAvail.
==========

to

==========
Use unsigned page indexes in CPDF_HintTables.

Fix up callers from CPDF_DataAvail.

Committed:
https://pdfium.googlesource.com/pdfium/+/e0cb687c71d555b55cc30ec59c9b338a0e83...
==========

[commit-bot: I haz the power, 2016-09-01 20:41:13]

Committed patchset #3 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/e0cb687c71d555b55cc30ec59c9b338a0e83...