Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: core/fpdfapi/fpdf_parser/include/cpdf_data_avail.h

Issue 2294383003: Use unsigned page indexes in CPDF_HintTables. (Closed)
Patch Set: more safe math Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp ('k') | fpdfsdk/fpdf_dataavail.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/fpdfapi/fpdf_parser/include/cpdf_data_avail.h
diff --git a/core/fpdfapi/fpdf_parser/include/cpdf_data_avail.h b/core/fpdfapi/fpdf_parser/include/cpdf_data_avail.h
index 4adedba36c29be00810fdcfa5a72c0dd9176c701..b93394cd8fcd2a84fdb7855dd3d1994e2a460ecd 100644
--- a/core/fpdfapi/fpdf_parser/include/cpdf_data_avail.h
+++ b/core/fpdfapi/fpdf_parser/include/cpdf_data_avail.h
@@ -97,7 +97,7 @@ class CPDF_DataAvail final {
DocAvailStatus IsDocAvail(DownloadHints* pHints);
void SetDocument(CPDF_Document* pDoc);
- DocAvailStatus IsPageAvail(int iPage, DownloadHints* pHints);
+ DocAvailStatus IsPageAvail(uint32_t dwPage, DownloadHints* pHints);
DocFormStatus IsFormAvail(DownloadHints* pHints);
DocLinearizationStatus IsLinearizedPDF();
FX_BOOL IsLinearized();
@@ -166,13 +166,14 @@ class CPDF_DataAvail final {
FX_BOOL LoadAllXref(DownloadHints* pHints);
FX_BOOL LoadAllFile(DownloadHints* pHints);
DocAvailStatus CheckLinearizedData(DownloadHints* pHints);
- FX_BOOL CheckPageAnnots(int iPage, DownloadHints* pHints);
+ FX_BOOL CheckPageAnnots(uint32_t dwPage, DownloadHints* pHints);
- DocAvailStatus CheckLinearizedFirstPage(int iPage, DownloadHints* pHints);
+ DocAvailStatus CheckLinearizedFirstPage(uint32_t dwPage,
+ DownloadHints* pHints);
FX_BOOL HaveResourceAncestor(CPDF_Dictionary* pDict);
- FX_BOOL CheckPage(int32_t iPage, DownloadHints* pHints);
+ FX_BOOL CheckPage(uint32_t dwPage, DownloadHints* pHints);
FX_BOOL LoadDocPages(DownloadHints* pHints);
- FX_BOOL LoadDocPage(int32_t iPage, DownloadHints* pHints);
+ FX_BOOL LoadDocPage(uint32_t dwPage, DownloadHints* pHints);
FX_BOOL CheckPageNode(PageNode& pageNodes,
int32_t iPage,
int32_t& iCount,
@@ -185,8 +186,8 @@ class CPDF_DataAvail final {
PageNode* pPageNode,
DownloadHints* pHints);
FX_BOOL CheckPageCount(DownloadHints* pHints);
- bool IsFirstCheck(int iPage);
- void ResetFirstCheck(int iPage);
+ bool IsFirstCheck(uint32_t dwPage);
+ void ResetFirstCheck(uint32_t dwPage);
FX_BOOL IsDataAvail(FX_FILESIZE offset, uint32_t size, DownloadHints* pHints);
FileAvail* const m_pFileAvail;
« no previous file with comments | « core/fpdfapi/fpdf_parser/cpdf_hint_tables.cpp ('k') | fpdfsdk/fpdf_dataavail.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698