Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h

Issue 2294383002: Make OffscreenCanvas a member of CanvasImageSource (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
index 641db101c3776b95175ab897a547e01a90086dd9..87e757d910baacaf2c7d67881b4c7c32981d0e0a 100644
--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.h
@@ -60,7 +60,7 @@ class Path2D;
class SVGMatrixTearOff;
class TextMetrics;
-typedef HTMLImageElementOrHTMLVideoElementOrHTMLCanvasElementOrImageBitmap CanvasImageSourceUnion;
+typedef HTMLImageElementOrHTMLVideoElementOrHTMLCanvasElementOrImageBitmapOrOffscreenCanvas CanvasImageSourceUnion;
class MODULES_EXPORT CanvasRenderingContext2D final : public CanvasRenderingContext, public BaseRenderingContext2D, public WebThread::TaskObserver, public SVGResourceClient {
DEFINE_WRAPPERTYPEINFO();
@@ -167,11 +167,15 @@ public:
void validateStateStack() final;
+ PassRefPtr<Image> getImage(SnapshotReason) const final;
+
bool isAccelerationOptimalForCanvasContent() const;
void resetUsageTracking();
- void incrementFrameCount() { m_usageCounters.numFramesSinceReset++; };
+ void incrementFrameCount() { m_usageCounters.numFramesSinceReset++; }
+
+ bool isPaintable() const final { return hasImageBuffer(); }
private:
friend class CanvasRenderingContext2DAutoRestoreSkCanvas;
@@ -224,12 +228,6 @@ private:
HashMap<String, Font> m_fontsResolvedUsingCurrentStyle;
bool m_pruneLocalFontCacheScheduled;
ListHashSet<String> m_fontLRUList;
-
- bool isPaintable() const final
- {
- NOTREACHED();
- return false;
- }
};
DEFINE_TYPE_CASTS(CanvasRenderingContext2D, CanvasRenderingContext, context,

Powered by Google App Engine
This is Rietveld 408576698