Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Unified Diff: net/http/http_response_info.cc

Issue 2294373002: Certificate Transparency: Remove the obsolete invalid sct status. (Closed)
Patch Set: Making common headers available to nacl code Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/http/http_response_info.cc
diff --git a/net/http/http_response_info.cc b/net/http/http_response_info.cc
index 4328b7ae2b64b9ab5680f67dc9fed463aebc2f00..e4bb70f94d136d287c7ab647db6a90b0fc42d601 100644
--- a/net/http/http_response_info.cc
+++ b/net/http/http_response_info.cc
@@ -10,6 +10,7 @@
#include "net/base/auth.h"
#include "net/base/io_buffer.h"
#include "net/base/net_errors.h"
+#include "net/cert/sct_status_flags.h"
#include "net/cert/signed_certificate_timestamp.h"
#include "net/cert/x509_certificate.h"
#include "net/http/http_response_headers.h"
@@ -239,6 +240,8 @@ bool HttpResponseInfo::InitFromPickle(const base::Pickle& pickle,
uint16_t status;
if (!sct.get() || !iter.ReadUInt16(&status))
return false;
+ if (!net::ct::IsValidSCTStatus(status))
+ return false;
ssl_info.signed_certificate_timestamps.push_back(
SignedCertificateTimestampAndStatus(
sct, static_cast<ct::SCTVerifyStatus>(status)));

Powered by Google App Engine
This is Rietveld 408576698