Certificate Transparency: Remove the obsolete invalid sct status.

net/http/http_response_info_unittest.cc

Index: net/http/http_response_info_unittest.cc
diff --git a/net/http/http_response_info_unittest.cc b/net/http/http_response_info_unittest.cc
index 75ae43532c4d71aeead410bbd4d3589a886d8afb..c1f28f7cabe25797ec7832b2697ff962fe82aee3 100644
--- a/net/http/http_response_info_unittest.cc
+++ b/net/http/http_response_info_unittest.cc
@@ -5,7 +5,10 @@
 #include "net/http/http_response_info.h"
 
 #include "base/pickle.h"
+#include "net/cert/signed_certificate_timestamp.h"
+#include "net/cert/signed_certificate_timestamp_and_status.h"
 #include "net/http/http_response_headers.h"
+#include "net/test/ct_test_util.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
@@ -90,6 +93,36 @@ TEST_F(HttpResponseInfoTest, AsyncRevalidationRequiredNotPersisted) {
   EXPECT_FALSE(restored_response_info.async_revalidation_required);
 }
 
+TEST_F(HttpResponseInfoTest, FailsInitFromPickleWithInvalidSCTStatus) {
+  // A valid certificate is needed for ssl_info.is_valid() to be true
+  // so that the SCTs would be serialized.
+  const std::string der_test_cert(net::ct::GetDerEncodedX509Cert());
+  response_info_.ssl_info.cert = net::X509Certificate::CreateFromBytes(
+      der_test_cert.data(), der_test_cert.length());
+
+  scoped_refptr<ct::SignedCertificateTimestamp> sct;
+  ct::GetX509CertSCT(&sct);

[Jeffrey Yasskin, 2016/09/15 19:10:14]

FYI, this fails to initialize the 'origin' field, which is then written to
response_info_, causing an MSan failure at
https://build.chromium.org/p/chromium.memory.full/builders/Linux%20MSan%20Tes...:

Uninitialized bytes in __msan_check_mem_is_initialized at offset 0 inside
[0x7ffcdf07e8b8, 4)
==31610==WARNING: MemorySanitizer: use-of-uninitialized-value
    #0 0xa7ce15a in WriteBytesCommon base/pickle.cc:478:3
    #1 0xa7ce15a in WriteBytesStatic<4> base/pickle.cc:443:0
    #2 0x98c5407 in WritePOD<int> base/pickle.h:367:5
    #3 0x98c5407 in WriteInt base/pickle.h:229:0
    #4 0x98c5407 in Persist net/cert/signed_certificate_timestamp.cc:43:0
    #5 0x991c383 in Persist net/http/http_response_info.cc:381:18
    #6 0x2cb75d0 in TestBody net/http/http_response_info_unittest.cc:111:18
    #7 0xa9af466 in HandleExceptionsInMethodIfSupported<testing::Test, void>
testing/gtest/src/gtest.cc:2458:12
    #8 0xa9af466 in Run testing/gtest/src/gtest.cc:2474:0
    #9 0xa9b2757 in Run testing/gtest/src/gtest.cc:2656:11
    #10 0xa9b3f7b in Run testing/gtest/src/gtest.cc:2774:28
    #11 0xa9d1121 in RunAllTests testing/gtest/src/gtest.cc:4647:43
    #12 0xa9d0124 in
HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>
testing/gtest/src/gtest.cc:2458:12
    #13 0xa9d0124 in Run testing/gtest/src/gtest.cc:4255:0
    #14 0xba78ae0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #15 0xba78ae0 in Run base/test/test_suite.cc:246:0
    #16 0xba7d487 in Run base/callback.h:64:12
    #17 0xba7d487 in LaunchUnitTestsInternal
base/test/launcher/unit_test_launcher.cc:206:0
    #18 0xba7ccfe in LaunchUnitTests
base/test/launcher/unit_test_launcher.cc:445:10
    #19 0x5f4b8a7 in main net/test/run_all_unittests.cc:59:10
    #20 0x7f6a633157ec in __libc_start_main
/build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226:0
    #21 0x870af0 in _start ??:0

  Uninitialized value was stored to memory at
    #0 0x98c57fd in Persist net/cert/signed_certificate_timestamp.cc:43:3
    #1 0x991c383 in Persist net/http/http_response_info.cc:381:18
    #2 0x2cb75d0 in TestBody net/http/http_response_info_unittest.cc:111:18
    #3 0xa9af466 in HandleExceptionsInMethodIfSupported<testing::Test, void>
testing/gtest/src/gtest.cc:2458:12
    #4 0xa9af466 in Run testing/gtest/src/gtest.cc:2474:0
    #5 0xa9b2757 in Run testing/gtest/src/gtest.cc:2656:11
    #6 0xa9b3f7b in Run testing/gtest/src/gtest.cc:2774:28
    #7 0xa9d1121 in RunAllTests testing/gtest/src/gtest.cc:4647:43
    #8 0xa9d0124 in
HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>
testing/gtest/src/gtest.cc:2458:12
    #9 0xa9d0124 in Run testing/gtest/src/gtest.cc:4255:0
    #10 0xba78ae0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #11 0xba78ae0 in Run base/test/test_suite.cc:246:0
    #12 0xba7d487 in Run base/callback.h:64:12
    #13 0xba7d487 in LaunchUnitTestsInternal
base/test/launcher/unit_test_launcher.cc:206:0
    #14 0xba7ccfe in LaunchUnitTests
base/test/launcher/unit_test_launcher.cc:445:10
    #15 0x5f4b8a7 in main net/test/run_all_unittests.cc:59:10
    #16 0x7f6a633157ec in __libc_start_main
/build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226:0

  Uninitialized value was created by a heap allocation
    #0 0x8da8c2 in operator new(unsigned long) ??:0
    #1 0xa68c2f8 in GetX509CertSCT net/test/ct_test_util.cc:220:14
    #2 0x2cb7451 in TestBody net/http/http_response_info_unittest.cc:104:3
    #3 0xa9af466 in HandleExceptionsInMethodIfSupported<testing::Test, void>
testing/gtest/src/gtest.cc:2458:12
    #4 0xa9af466 in Run testing/gtest/src/gtest.cc:2474:0
    #5 0xa9b2757 in Run testing/gtest/src/gtest.cc:2656:11
    #6 0xa9b3f7b in Run testing/gtest/src/gtest.cc:2774:28
    #7 0xa9d1121 in RunAllTests testing/gtest/src/gtest.cc:4647:43
    #8 0xa9d0124 in
HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool>
testing/gtest/src/gtest.cc:2458:12
    #9 0xa9d0124 in Run testing/gtest/src/gtest.cc:4255:0
    #10 0xba78ae0 in RUN_ALL_TESTS testing/gtest/include/gtest/gtest.h:2237:46
    #11 0xba78ae0 in Run base/test/test_suite.cc:246:0
    #12 0xba7d487 in Run base/callback.h:64:12
    #13 0xba7d487 in LaunchUnitTestsInternal
base/test/launcher/unit_test_launcher.cc:206:0
    #14 0xba7ccfe in LaunchUnitTests
base/test/launcher/unit_test_launcher.cc:445:10
    #15 0x5f4b8a7 in main net/test/run_all_unittests.cc:59:10
    #16 0x7f6a633157ec in __libc_start_main
/build/eglibc-oqps9y/eglibc-2.15/csu/libc-start.c:226:0

SUMMARY: MemorySanitizer: use-of-uninitialized-value
(/b/swarming/w/irP1cChJ/out/Release/net_unittests+0xa7ce15a)

+
+  response_info_.ssl_info.signed_certificate_timestamps.push_back(
+      SignedCertificateTimestampAndStatus(
+          sct, ct::SCTVerifyStatus::SCT_STATUS_LOG_UNKNOWN));
+
+  base::Pickle pickle;
+  response_info_.Persist(&pickle, false, false);
+  bool truncated = false;
+  net::HttpResponseInfo restored_response_info;
+  EXPECT_TRUE(restored_response_info.InitFromPickle(pickle, &truncated));
+
+  response_info_.ssl_info.signed_certificate_timestamps.push_back(
+      SignedCertificateTimestampAndStatus(sct,
+                                          static_cast<ct::SCTVerifyStatus>(2)));
+  base::Pickle pickle_invalid;
+  response_info_.Persist(&pickle_invalid, false, false);
+  net::HttpResponseInfo restored_invalid_response;
+  EXPECT_FALSE(
+      restored_invalid_response.InitFromPickle(pickle_invalid, &truncated));
+}
+
 }  // namespace
 
 }  // namespace net