Certificate Transparency: Remove the obsolete invalid sct status.

net/cert/sct_status_flags.h

Index: net/cert/sct_status_flags.h
diff --git a/net/cert/sct_status_flags.h b/net/cert/sct_status_flags.h
index cdd63b9ffb2181e1fa1b60f43aa53769513a3e2e..7967e381377c895638dea8a8ad7f89a33aac5c0e 100644
--- a/net/cert/sct_status_flags.h
+++ b/net/cert/sct_status_flags.h
@@ -5,6 +5,8 @@
 #ifndef NET_CERT_SCT_STATUS_FLAGS_H_
 #define NET_CERT_SCT_STATUS_FLAGS_H_
 
+#include "net/base/net_export.h"

[Ryan Sleevi, 2016/09/01 21:29:46]

#include <stdint>

#include "net/base/net_export.h"

(But see below)

[Eran Messeri, 2016/09/09 09:38:14]

Done.

+
 namespace net {
 
 namespace ct {
@@ -21,12 +23,8 @@ enum SCTVerifyStatus {
   // The SCT is from an unknown log, so we cannot verify its signature.
   SCT_STATUS_LOG_UNKNOWN = 1,
 
-  // This value is deprecated and should not be used. It has been split
-  // into INVALID_SIGNATURE and INVALID_TIMESTAMP to represent the
-  // different reasons an SCT could be invalid. Though it is no longer
-  // in use, it is preserved here because it may be present in
-  // serialized messages.
-  SCT_STATUS_INVALID = 2,
+  // Obsolete. Kept here to avoid reuse.
+  // SCT_STATUS_INVALID = 2,
 
   // The SCT is from a known log, and the signature is valid.
   SCT_STATUS_OK = 3,
@@ -42,6 +40,10 @@ enum SCTVerifyStatus {
   SCT_STATUS_MAX = SCT_STATUS_INVALID_TIMESTAMP,
 };
 
+// Returns true if |status| denotes a valid value in SCTVerifyStatus, which
+// is all current values in the enum except SCT_STATUS_NONE.
+NET_EXPORT bool IsValidSCTStatus(uint32_t status);

[Ryan Sleevi, 2016/09/01 21:29:46]

STYLE: 
https://google.github.io/styleguide/cppguide.html#Integer_Types
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

Option 1: IsValidSCTStatus(int status)
Option 2: C++11 enum-base for SCTVerifyStatus (line 17), as

enum SCTVerifyStatus : uint32_t {


The reason I highlight the mismatch is that SCTVerifyStatus is not a fixed
underlying type (e.g. int-or-implementation-defined-larger). Either approach
harmonizes them, but I've got a preference for Option 2 because that's
guaranteed-explicit :)

[Eran Messeri, 2016/09/09 09:38:14]

Done, used the 2nd option.

+
 }  // namespace ct
 
 }  // namespace net