Certificate Transparency: Remove the obsolete invalid sct status.

net/cert/sct_status_flags.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_CERT_SCT_STATUS_FLAGS_H_
 #define NET_CERT_SCT_STATUS_FLAGS_H_
 
+#include "net/base/net_export.h"

[Ryan Sleevi, 2016/09/01 21:29:46]

#include <stdint>

#include "net/base/net_export.h"

(But see below)

[Eran Messeri, 2016/09/09 09:38:14]

Done.

+
 namespace net {
 
 namespace ct {
 
 // The possible verification statuses for a SignedCertificateTimestamp.
 // Note: The numeric values are used within histograms and should not change
 // or be re-assigned.
 enum SCTVerifyStatus {
   // Not a real status, this just prevents a default int value from being
   // mis-interpreseted as a valid status.
   // Also used to count SCTs that cannot be decoded in the histogram.
   SCT_STATUS_NONE = 0,
 
   // The SCT is from an unknown log, so we cannot verify its signature.
   SCT_STATUS_LOG_UNKNOWN = 1,
 
-  // This value is deprecated and should not be used. It has been split
-  // into INVALID_SIGNATURE and INVALID_TIMESTAMP to represent the
-  // different reasons an SCT could be invalid. Though it is no longer
-  // in use, it is preserved here because it may be present in
-  // serialized messages.
-  SCT_STATUS_INVALID = 2,
+  // Obsolete. Kept here to avoid reuse.
+  // SCT_STATUS_INVALID = 2,
 
   // The SCT is from a known log, and the signature is valid.
   SCT_STATUS_OK = 3,
 
   // The SCT is from a known log, but the signature is invalid.
   SCT_STATUS_INVALID_SIGNATURE = 4,
 
   // The SCT is from a known log, but the timestamp is in the future.
   SCT_STATUS_INVALID_TIMESTAMP = 5,
 
   // Used to bound the enum values. Since this enum is passed over IPC,
   // the last value must be a valid one (rather than one past a valid one).
   SCT_STATUS_MAX = SCT_STATUS_INVALID_TIMESTAMP,
 };
 
+// Returns true if |status| denotes a valid value in SCTVerifyStatus, which
+// is all current values in the enum except SCT_STATUS_NONE.
+NET_EXPORT bool IsValidSCTStatus(uint32_t status);

[Ryan Sleevi, 2016/09/01 21:29:46]

STYLE: 
https://google.github.io/styleguide/cppguide.html#Integer_Types
https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...

Option 1: IsValidSCTStatus(int status)
Option 2: C++11 enum-base for SCTVerifyStatus (line 17), as

enum SCTVerifyStatus : uint32_t {


The reason I highlight the mismatch is that SCTVerifyStatus is not a fixed
underlying type (e.g. int-or-implementation-defined-larger). Either approach
harmonizes them, but I've got a preference for Option 2 because that's
guaranteed-explicit :)

[Eran Messeri, 2016/09/09 09:38:14]

Done, used the 2nd option.

+
 }  // namespace ct
 
 }  // namespace net
 
 #endif  // NET_CERT_SCT_STATUS_FLAGS_H_