Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: content/common/ssl_status_serialization_unittest.cc

Issue 2294373002: Certificate Transparency: Remove the obsolete invalid sct status. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/ssl_status_serialization_unittest.cc
diff --git a/content/common/ssl_status_serialization_unittest.cc b/content/common/ssl_status_serialization_unittest.cc
index 9c49b42e9579b132657e073ada6f52792574c92a..9e9c361a709d1c76f531e14b07f8155a4092b177 100644
--- a/content/common/ssl_status_serialization_unittest.cc
+++ b/content/common/ssl_status_serialization_unittest.cc
@@ -148,19 +148,19 @@ TEST(SSLStatusSerializationTest, DeserializeBogusSCTVerifyStatus) {
EXPECT_PRED2(SSLStatusAreEqual, SSLStatus(), deserialized);
}
-// Test that SCTVerifyStatus INVALID can be deserialized; even though
+// Test that SCTVerifyStatus INVALID cannot be deserialized; even though
// this value is deprecated, it may still appear in previously written
-// disk cache entries. Regression test for https://crbug.com/640296
+// disk cache entries which should be invalidated.
TEST(SSLStatusSerializationTest, DeserializeInvalidSCT) {
SSLStatus status;
SetTestStatus(&status);
status.sct_statuses.push_back(
- static_cast<net::ct::SCTVerifyStatus>(net::ct::SCT_STATUS_INVALID));
+ static_cast<net::ct::SCTVerifyStatus>(2));
std::string serialized = SerializeSecurityInfo(status);
- SSLStatus deserialized;
- ASSERT_TRUE(DeserializeSecurityInfo(serialized, &deserialized));
- EXPECT_PRED2(SSLStatusAreEqual, status, deserialized);
+ SSLStatus invalid_deserialized;
+ ASSERT_FALSE(DeserializeSecurityInfo(serialized, &invalid_deserialized));
+ EXPECT_PRED2(SSLStatusAreEqual, SSLStatus(), invalid_deserialized);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698