Certificate Transparency: Remove the obsolete invalid sct status.

content/common/ssl_status_serialization.cc

Index: content/common/ssl_status_serialization.cc
diff --git a/content/common/ssl_status_serialization.cc b/content/common/ssl_status_serialization.cc
index 3785d277eafc0a1cc70ce2a39056563bda47803d..eb914c005df59fe7127263657b8d716c27409777 100644
--- a/content/common/ssl_status_serialization.cc
+++ b/content/common/ssl_status_serialization.cc
@@ -31,9 +31,6 @@ bool CheckSecurityStyle(int security_style) {
 bool CheckSCTStatus(uint32_t sct_status) {
   switch (sct_status) {
     case net::ct::SCT_STATUS_LOG_UNKNOWN:
-    // INVALID is deprecated and should not be used anymore, but it
-    // might have been previously written into the disk cache.
-    case net::ct::SCT_STATUS_INVALID:
     case net::ct::SCT_STATUS_INVALID_SIGNATURE:
     case net::ct::SCT_STATUS_OK:
     case net::ct::SCT_STATUS_INVALID_TIMESTAMP:
@@ -42,6 +39,9 @@ bool CheckSCTStatus(uint32_t sct_status) {
       // SCT_STATUS_NONE should never happen, so it isn't valid to
       // receive a status of NONE in a serialized SSLStatus.
       return false;
+    case 2:

[estark, 2016/08/31 22:03:33]

Is this necessary? Can we just fall through to line 46?

[Ryan Sleevi, 2016/09/01 00:01:29]

+1

[Eran Messeri, 2016/09/01 14:16:34]

Done.

+      // Was SCT_STATUS_INVALID, which was removed.
+      return false;
   }
   return false;
 }