Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1419)

Issue 2294223004: Work around PanGestureRecognizer iOS10 issue. (Closed)

Created:
4 years, 3 months ago by justincohen
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Work around PanGestureRecognizer iOS10 issue. In iOS10, sometimes a PanGestureRecognizer will fire a touchesMoved even after touchesBegan sets its state to |UIGestureRecognizerStateFailed|. Somehow the state is re-set to UIGestureRecognizerStatePossible, and ends up in moved. Checking if |_startPoint| has been set is a secondary way to catch for failed gestures. It appears setting failed in touchesMoved still always works -- this issue only seems to be related to setting Failure in touchesBegan, and only sometimes. BUG=640611 Review-Url: https://codereview.chromium.org/2281303002 Cr-Commit-Position: refs/heads/master@{#415004} (cherry picked from commit 95144337ab1af223377554b7ca838de787d8080e) Committed: https://chromium.googlesource.com/chromium/src/+/792336ddbb2be085276faebbec4a8e83bfd0e989

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
justincohen
4 years, 3 months ago (2016-08-31 18:40:55 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
792336ddbb2be085276faebbec4a8e83bfd0e989.

Powered by Google App Engine
This is Rietveld 408576698