Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 2281303002: Work around PanGestureRecognizer iOS10 issue. (Closed)

Created:
4 years, 3 months ago by justincohen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Work around PanGestureRecognizer iOS10 issue. In iOS10, sometimes a PanGestureRecognizer will fire a touchesMoved even after touchesBegan sets its state to |UIGestureRecognizerStateFailed|. Somehow the state is re-set to UIGestureRecognizerStatePossible, and ends up in moved. Checking if |_startPoint| has been set is a secondary way to catch for failed gestures. It appears setting failed in touchesMoved still always works -- this issue only seems to be related to setting Failure in touchesBegan, and only sometimes. BUG=640611 Committed: https://crrev.com/95144337ab1af223377554b7ca838de787d8080e Cr-Commit-Position: refs/heads/master@{#415004}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M ios/chrome/browser/ui/side_swipe_gesture_recognizer.mm View 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
justincohen
Thoughts?
4 years, 3 months ago (2016-08-26 21:49:08 UTC) #2
rohitrao (ping after 24h)
lgtm
4 years, 3 months ago (2016-08-29 13:30:22 UTC) #3
rohitrao (ping after 24h)
This seems pretty safe for M53.
4 years, 3 months ago (2016-08-29 13:31:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2281303002/1
4 years, 3 months ago (2016-08-29 13:34:22 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-29 14:10:42 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 14:12:23 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/95144337ab1af223377554b7ca838de787d8080e
Cr-Commit-Position: refs/heads/master@{#415004}

Powered by Google App Engine
This is Rietveld 408576698