Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 2294193003: Unify DeclarationScope::Analyze (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Toon Verwaest, marja
CC:
v8-reviews_googlegroups.com, Yang
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Unify DeclarationScope::Analyze R=marja@chromium.org TBR=verwaest@chromium.org BUG= Committed: https://crrev.com/5b25cbb5038819b6aca98997c878206af62912ff Cr-Commit-Position: refs/heads/master@{#39037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -32 lines) Patch
M src/ast/scopes.h View 4 chunks +4 lines, -6 lines 0 comments Download
M src/ast/scopes.cc View 5 chunks +7 lines, -22 lines 0 comments Download
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-loop-assignment-analysis.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (8 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-08-31 07:42:29 UTC) #1
jochen (gone - plz use gerrit)
+verwaest for debugger
4 years, 3 months ago (2016-08-31 07:43:05 UTC) #5
marja
lgtm
4 years, 3 months ago (2016-08-31 07:47:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294193003/1
4 years, 3 months ago (2016-08-31 08:02:32 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 08:47:13 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 08:47:27 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b25cbb5038819b6aca98997c878206af62912ff
Cr-Commit-Position: refs/heads/master@{#39037}

Powered by Google App Engine
This is Rietveld 408576698