Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 2294043002: DevTools: make <webview> remote debugging clients happy - they expect 'webview' target type. (Closed)

Created:
4 years, 3 months ago by pfeldman
Modified:
4 years, 3 months ago
Reviewers:
achuithb, dgozman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: make <webview> remote debugging clients happy - they expect 'webview' target type. BUG=641865 TBR= Committed: https://crrev.com/51a16bde0ffb354c8ffbce3999c4b718f3fcaab3 Cr-Commit-Position: refs/heads/master@{#415438}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/browser/devtools/chrome_devtools_manager_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
pfeldman
4 years, 3 months ago (2016-08-30 20:35:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2294043002/1
4 years, 3 months ago (2016-08-30 20:36:23 UTC) #5
achuithb
lgtm
4 years, 3 months ago (2016-08-30 21:25:31 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 21:42:01 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 21:43:38 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/51a16bde0ffb354c8ffbce3999c4b718f3fcaab3
Cr-Commit-Position: refs/heads/master@{#415438}

Powered by Google App Engine
This is Rietveld 408576698