Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Side by Side Diff: chrome/browser/devtools/chrome_devtools_manager_delegate.h

Issue 2294043002: DevTools: make <webview> remote debugging clients happy - they expect 'webview' target type. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/chrome_devtools_manager_delegate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_ 5 #ifndef CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
6 #define CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_ 6 #define CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/macros.h" 11 #include "base/macros.h"
12 #include "content/public/browser/devtools_manager_delegate.h" 12 #include "content/public/browser/devtools_manager_delegate.h"
13 13
14 class DevToolsNetworkProtocolHandler; 14 class DevToolsNetworkProtocolHandler;
15 15
16 class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate { 16 class ChromeDevToolsManagerDelegate : public content::DevToolsManagerDelegate {
17 public: 17 public:
18 static char kTypeApp[]; 18 static char kTypeApp[];
19 static char kTypeBackgroundPage[]; 19 static char kTypeBackgroundPage[];
20 static char kTypeWebView[];
20 21
21 ChromeDevToolsManagerDelegate(); 22 ChromeDevToolsManagerDelegate();
22 ~ChromeDevToolsManagerDelegate() override; 23 ~ChromeDevToolsManagerDelegate() override;
23 24
24 // content::DevToolsManagerDelegate implementation. 25 // content::DevToolsManagerDelegate implementation.
25 void Inspect(content::DevToolsAgentHost* agent_host) override; 26 void Inspect(content::DevToolsAgentHost* agent_host) override;
26 void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host, 27 void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,
27 bool attached) override; 28 bool attached) override;
28 base::DictionaryValue* HandleCommand( 29 base::DictionaryValue* HandleCommand(
29 content::DevToolsAgentHost* agent_host, 30 content::DevToolsAgentHost* agent_host,
30 base::DictionaryValue* command_dict) override; 31 base::DictionaryValue* command_dict) override;
31 std::string GetTargetType(content::RenderFrameHost* host) override; 32 std::string GetTargetType(content::RenderFrameHost* host) override;
32 std::string GetTargetTitle(content::RenderFrameHost* host) override; 33 std::string GetTargetTitle(content::RenderFrameHost* host) override;
33 scoped_refptr<content::DevToolsAgentHost> CreateNewTarget( 34 scoped_refptr<content::DevToolsAgentHost> CreateNewTarget(
34 const GURL& url) override; 35 const GURL& url) override;
35 36
36 private: 37 private:
37 std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_; 38 std::unique_ptr<DevToolsNetworkProtocolHandler> network_protocol_handler_;
38 39
39 DISALLOW_COPY_AND_ASSIGN(ChromeDevToolsManagerDelegate); 40 DISALLOW_COPY_AND_ASSIGN(ChromeDevToolsManagerDelegate);
40 }; 41 };
41 42
42 #endif // CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_ 43 #endif // CHROME_BROWSER_DEVTOOLS_CHROME_DEVTOOLS_MANAGER_DELEGATE_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/devtools/chrome_devtools_manager_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698