[builtins] Create StringToNumber helper.

[builtins] Create StringToNumber helper.

Move StringToNumber builtin implementation to helper function in
CodeStubAssembler.

BUG=

Committed: https://crrev.com/5e6a1abf54ae21e67141feb68ba35147e693217b
Cr-Commit-Position: refs/heads/master@{#39249}

[alegil02, 2016-08-30 16:12:03]

Description was changed from

==========
[builtins] Create inline StringToNumber and wrapper.

Move StringToNumber builtin implementation to inline function and add
wrapper. Create macros for inline unary op builtins.

BUG=
==========

to

==========
[builtins] Create inline StringToNumber and wrapper.

Move StringToNumber builtin implementation to inline function and add
wrapper. Create macros for inline unary op builtins.

BUG=
==========

[alegil02, 2016-08-30 16:12:04]

alexander.gilday2@arm.com changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2016-08-30 17:16:49]

https://codereview.chromium.org/2293943002/diff/1/src/builtins/builtins.h
File src/builtins/builtins.h (right):

https://codereview.chromium.org/2293943002/diff/1/src/builtins/builtins.h#new...
src/builtins/builtins.h:44: // TFS_UNARY_OP:
Don't introduce a new category here. Instead just put the helper function on the
CodeStubAssembler as we did for all the other helpers, and call it for the
StringToNumber builtin and for the conversion builtins.

[alegil02, 2016-09-01 14:59:48]

On 2016/08/30 17:16:49, Benedikt Meurer wrote:
> https://codereview.chromium.org/2293943002/diff/1/src/builtins/builtins.h
> File src/builtins/builtins.h (right):
> 
>
https://codereview.chromium.org/2293943002/diff/1/src/builtins/builtins.h#new...
> src/builtins/builtins.h:44: // TFS_UNARY_OP:
> Don't introduce a new category here. Instead just put the helper function on
the
> CodeStubAssembler as we did for all the other helpers, and call it for the
> StringToNumber builtin and for the conversion builtins.

Fixed. PTAL.

[alegil02, 2016-09-01 15:02:45]

Description was changed from

==========
[builtins] Create inline StringToNumber and wrapper.

Move StringToNumber builtin implementation to inline function and add
wrapper. Create macros for inline unary op builtins.

BUG=
==========

to

==========
[builtins] Create StringToNumber helper.
    
Move StringToNumber builtin implementation to helper function in
CodeStubAssembler.

BUG=
==========

[Benedikt Meurer, 2016-09-02 04:23:48]

Thanks. LGTM once nits are addressed.

https://codereview.chromium.org/2293943002/diff/20001/src/builtins/builtins-c...
File src/builtins/builtins-conversion.cc (left):

https://codereview.chromium.org/2293943002/diff/20001/src/builtins/builtins-c...
src/builtins/builtins-conversion.cc:117: Node* input =
assembler->Parameter(Descriptor::kArgument);
Nit: Please leave the explicit input/context assignment lines for consistency.

https://codereview.chromium.org/2293943002/diff/20001/src/code-stub-assembler.cc
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2293943002/diff/20001/src/code-stub-assembler...
src/code-stub-assembler.cc:2236: // Note: We cannot tail call to the runtime
here, as js-to-wasm
Nit: remove this note as now with the helper we cannot tail call anyways.

[alegil02, 2016-09-07 12:44:20]

On 2016/09/02 04:23:48, Benedikt Meurer wrote:
> Thanks. LGTM once nits are addressed.
> 
>
https://codereview.chromium.org/2293943002/diff/20001/src/builtins/builtins-c...
> File src/builtins/builtins-conversion.cc (left):
> 
>
https://codereview.chromium.org/2293943002/diff/20001/src/builtins/builtins-c...
> src/builtins/builtins-conversion.cc:117: Node* input =
> assembler->Parameter(Descriptor::kArgument);
> Nit: Please leave the explicit input/context assignment lines for consistency.
> 
>
https://codereview.chromium.org/2293943002/diff/20001/src/code-stub-assembler.cc
> File src/code-stub-assembler.cc (right):
> 
>
https://codereview.chromium.org/2293943002/diff/20001/src/code-stub-assembler...
> src/code-stub-assembler.cc:2236: // Note: We cannot tail call to the runtime
> here, as js-to-wasm
> Nit: remove this note as now with the helper we cannot tail call anyways.

Fixed nits. PTAL.

[alegil02, 2016-09-07 12:54:59]

The CQ bit was checked by alexander.gilday2@arm.com

[alegil02, 2016-09-07 12:55:00]

The patchset sent to the CQ was uploaded after l-g-t-m from bmeurer@chromium.org
Link to the patchset: https://codereview.chromium.org/2293943002/#ps40001
(title: "Addressed nits.")

[commit-bot: I haz the power, 2016-09-07 12:55:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 13:20:06]

Description was changed from

==========
[builtins] Create StringToNumber helper.
    
Move StringToNumber builtin implementation to helper function in
CodeStubAssembler.

BUG=
==========

to

==========
[builtins] Create StringToNumber helper.
    
Move StringToNumber builtin implementation to helper function in
CodeStubAssembler.

BUG=
==========

[commit-bot: I haz the power, 2016-09-07 13:20:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-07 13:20:35]

Description was changed from

==========
[builtins] Create StringToNumber helper.
    
Move StringToNumber builtin implementation to helper function in
CodeStubAssembler.

BUG=
==========

to

==========
[builtins] Create StringToNumber helper.

Move StringToNumber builtin implementation to helper function in
CodeStubAssembler.

BUG=

Committed: https://crrev.com/5e6a1abf54ae21e67141feb68ba35147e693217b
Cr-Commit-Position: refs/heads/master@{#39249}
==========

[commit-bot: I haz the power, 2016-09-07 13:20:36]

Patchset 3 (id:??) landed as
https://crrev.com/5e6a1abf54ae21e67141feb68ba35147e693217b
Cr-Commit-Position: refs/heads/master@{#39249}