[builtins] Create StringToNumber helper.

src/builtins/builtins.h

 // Copyright 2011 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_BUILTINS_BUILTINS_H_
 #define V8_BUILTINS_BUILTINS_H_
 
 #include "src/base/flags.h"
 #include "src/handles.h"
 
@@ skipping 23 matching lines @@
   V(Make##C##CodeYoungAgainEvenMarking)
 
 // CPP: Builtin in C++. Entered via BUILTIN_EXIT frame.
 //      Args: name
 // API: Builtin in C++ for API callbacks. Entered via EXIT frame.
 //      Args: name
 // TFJ: Builtin in Turbofan, with JS linkage (callable as Javascript function).
 //      Args: name, arguments count
 // TFS: Builtin in Turbofan, with CodeStub linkage.
 //      Args: name, code kind, extra IC state, interface descriptor
+// TFS_UNARY_OP:

[Benedikt Meurer, 2016/08/30 17:16:49]

Don't introduce a new category here. Instead just put the helper function on the
CodeStubAssembler as we did for all the other helpers, and call it for the
StringToNumber builtin and for the conversion builtins.

+//      Builtin in Turbofan, with CudeStub linkage and inlinable function.
+//      Args: name, code kind, extra IC state, interface descriptor
 // ASM: Builtin in platform-dependent assembly.
 //      Args: name
 // ASH: Handlers implemented in platform-dependent assembly.
 //      Args: name, code kind, extra IC state
 // DBG: Builtin in platform-dependent assembly, used by the debugger.
 //      Args: name
-#define BUILTIN_LIST(CPP, API, TFJ, TFS, ASM, ASH, DBG)                       \
+#define BUILTIN_LIST(CPP, API, TFJ, TFS, TFS_UNARY_OP, ASM, ASH, DBG)         \
   ASM(Abort)                                                                  \
   /* Handlers */                                                              \
   ASH(KeyedLoadIC_Megamorphic, KEYED_LOAD_IC, kNoExtraICState)                \
   ASM(KeyedLoadIC_Miss)                                                       \
   ASH(KeyedLoadIC_Slow, HANDLER, Code::KEYED_LOAD_IC)                         \
   ASH(KeyedStoreIC_Megamorphic, KEYED_STORE_IC, kNoExtraICState)              \
   ASH(KeyedStoreIC_Megamorphic_Strict, KEYED_STORE_IC,                        \
       StoreICState::kStrictModeState)                                         \
   ASM(KeyedStoreIC_Miss)                                                      \
   ASH(KeyedStoreIC_Slow, HANDLER, Code::KEYED_STORE_IC)                       \
@@ skipping 110 matching lines @@
   /* Type conversions */                                                      \
   TFS(ToBoolean, BUILTIN, kNoExtraICState, TypeConversion)                    \
   TFS(OrdinaryToPrimitive_Number, BUILTIN, kNoExtraICState, TypeConversion)   \
   TFS(OrdinaryToPrimitive_String, BUILTIN, kNoExtraICState, TypeConversion)   \
   TFS(NonPrimitiveToPrimitive_Default, BUILTIN, kNoExtraICState,              \
       TypeConversion)                                                         \
   TFS(NonPrimitiveToPrimitive_Number, BUILTIN, kNoExtraICState,               \
       TypeConversion)                                                         \
   TFS(NonPrimitiveToPrimitive_String, BUILTIN, kNoExtraICState,               \
       TypeConversion)                                                         \
-  TFS(StringToNumber, BUILTIN, kNoExtraICState, TypeConversion)               \
+  TFS_UNARY_OP(StringToNumber, BUILTIN, kNoExtraICState, TypeConversion)      \
   TFS(NonNumberToNumber, BUILTIN, kNoExtraICState, TypeConversion)            \
   ASM(ToNumber)                                                               \
                                                                               \
   /* Built-in functions for Javascript */                                     \
   /* Special internal builtins */                                             \
   CPP(EmptyFunction)                                                          \
   CPP(Illegal)                                                                \
   CPP(RestrictedFunctionPropertiesThrower)                                    \
   CPP(RestrictedStrictArgumentsPropertiesThrower)                             \
   CPP(UnsupportedThrower)                                                     \
@@ skipping 334 matching lines @@
   CPP(TypedArrayPrototypeBuffer)                                              \
   /* ES6 section 22.2.3.2 get %TypedArray%.prototype.byteLength */            \
   TFJ(TypedArrayPrototypeByteLength, 1)                                       \
   /* ES6 section 22.2.3.3 get %TypedArray%.prototype.byteOffset */            \
   TFJ(TypedArrayPrototypeByteOffset, 1)                                       \
   /* ES6 section 22.2.3.18 get %TypedArray%.prototype.length */               \
   TFJ(TypedArrayPrototypeLength, 1)
 
 #define IGNORE_BUILTIN(...)
 
-#define BUILTIN_LIST_ALL(V) BUILTIN_LIST(V, V, V, V, V, V, V)
+#define BUILTIN_LIST_ALL(V) BUILTIN_LIST(V, V, V, V, V, V, V, V)
 
 #define BUILTIN_LIST_C(V)                                            \
   BUILTIN_LIST(V, V, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
-               IGNORE_BUILTIN, IGNORE_BUILTIN)
+               IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN)
 
 #define BUILTIN_LIST_A(V)                                                      \
   BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
-               V, V, V)
+               IGNORE_BUILTIN, V, V, V)
 
 #define BUILTIN_LIST_DBG(V)                                                    \
   BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, \
-               IGNORE_BUILTIN, IGNORE_BUILTIN, V)
+               IGNORE_BUILTIN, IGNORE_BUILTIN, IGNORE_BUILTIN, V)
 
 // Forward declarations.
 class CodeStubAssembler;
 class ObjectVisitor;
 
+namespace compiler {
+class Node;
+}
+
 class Builtins {
  public:
   ~Builtins();
 
   // Generate all builtin code objects. Should be called once during
   // isolate initialization.
   void SetUp(Isolate* isolate, bool create_heap_objects);
   void TearDown();
 
   // Garbage collection support.
@@ skipping 82 matching lines @@
   static void Generate_DatePrototype_GetField(MacroAssembler* masm,
                                               int field_index);
 
   enum class MathMaxMinKind { kMax, kMin };
   static void Generate_MathMaxMin(MacroAssembler* masm, MathMaxMinKind kind);
 
 #define DECLARE_ASM(Name, ...) \
   static void Generate_##Name(MacroAssembler* masm);
 #define DECLARE_TF(Name, ...) \
   static void Generate_##Name(CodeStubAssembler* csasm);
+#define DECLARE_TF_UNARY_OP(Name, ...)                                 \
+  static compiler::Node* GenerateImpl_##Name(CodeStubAssembler* csasm, \
+                                             compiler::Node* input,    \
+                                             compiler::Node* context); \
+  static void Generate_##Name(CodeStubAssembler* csasm);
 
   BUILTIN_LIST(IGNORE_BUILTIN, IGNORE_BUILTIN, DECLARE_TF, DECLARE_TF,
-               DECLARE_ASM, DECLARE_ASM, DECLARE_ASM)
+               DECLARE_TF_UNARY_OP, DECLARE_ASM, DECLARE_ASM, DECLARE_ASM)
 
 #undef DECLARE_ASM
 #undef DECLARE_TF
+#undef DECLARE_TF_UNARY_OP
 
   // Note: These are always Code objects, but to conform with
   // IterateBuiltins() above which assumes Object**'s for the callback
   // function f, we use an Object* array here.
   Object* builtins_[builtin_count];
   bool initialized_;
 
   friend class Isolate;
 
   DISALLOW_COPY_AND_ASSIGN(Builtins);
 };
 
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_BUILTINS_BUILTINS_H_