Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2293903002: Revert of Split RootScrollerController into top-document and child-document classes (Closed)

Created:
4 years, 3 months ago by lfg
Modified:
4 years, 3 months ago
Reviewers:
bokan, tdresser
CC:
chromium-reviews, kenneth.christiansen, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@rootScrollerIFrames2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Split RootScrollerController into top-document and child-document classes (patchset #3 id:40001 of https://codereview.chromium.org/2280453002/ ) Reason for revert: Causes oopif renderers to die. See https://crbug.com/641775 Original issue's description: > Split RootScrollerController into top-document and child-document classes > > Work on making RootScrollerController work across iframes revealed that there's > two responsibilities that need management. All frames need a > RootScrollerController to manage the Element currently set as root scroller and > determine which Element should eventually become the effective root scroller. > In addition, we need the RootScrollerController to manage the > ViewportApplyScroll and set it on the appropriate element. Since only one > Element on the whole page needs this callback set, it makes sense that only the > top document should have this responsibility. Experience with classes like > FrameView and EventHandler shows that this may be better served by subclassing > the top level object rather than having isMainFrame() checks intermingled with > the other code. > > BUG=505516 > > Committed: https://crrev.com/f8bc5669c399f88dc57d6a8832bc233db306c3c7 > Cr-Commit-Position: refs/heads/master@{#414796} TBR=tdresser@chromium.org,bokan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=505516

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -321 lines) Patch
M third_party/WebKit/Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 2 chunks +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/RootScrollerController.h View 3 chunks +36 lines, -41 lines 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/RootScrollerController.cpp View 5 chunks +145 lines, -89 lines 0 comments Download
D third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.h View 1 chunk +0 lines, -72 lines 0 comments Download
D third_party/WebKit/Source/core/page/scrolling/TopDocumentRootScrollerController.cpp View 1 chunk +0 lines, -111 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
lfg
Created Revert of Split RootScrollerController into top-document and child-document classes
4 years, 3 months ago (2016-08-30 14:06:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293903002/1
4 years, 3 months ago (2016-08-30 14:07:03 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/260084) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-08-30 14:09:39 UTC) #5
lfg
4 years, 3 months ago (2016-08-30 14:37:15 UTC) #7
Message was sent while issue was closed.
On 2016/08/30 14:09:39, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

The revert does not apply cleanly anymore, since this is not on the M54 branch,
let's just try to fix the bug.

Powered by Google App Engine
This is Rietveld 408576698