Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2293883002: Make incremental marking tracing format consistent with GC tracing. (Closed)

Created:
4 years, 3 months ago by ulan
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make incremental marking tracing format consistent with GC tracing. Now incremental marking tracing outputs isolate and timestamp: [41894:0x21efec0] 17253 ms: [IncrementalMarking] Start (old space step) This patch also adds walltime duration of incremental marking to GC trace output. BUG= Committed: https://crrev.com/bcf4c66b66c0ac21e050f466ccb2b4dc90486aaf Cr-Commit-Position: refs/heads/master@{#39016}

Patch Set 1 #

Patch Set 2 : Adjust GCTracer::Print #

Patch Set 3 : x #

Patch Set 4 : Move marking restart function to inl file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -100 lines) Patch
M src/heap/gc-tracer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 9 chunks +36 lines, -35 lines 0 comments Download
M src/heap/heap.cc View 7 chunks +25 lines, -26 lines 0 comments Download
M src/heap/incremental-marking.h View 1 2 3 1 chunk +1 line, -8 lines 0 comments Download
M src/heap/incremental-marking.cc View 1 2 3 20 chunks +46 lines, -31 lines 0 comments Download
M src/heap/incremental-marking-inl.h View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
M src/isolate.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ulan
PTAL
4 years, 3 months ago (2016-08-30 12:52:22 UTC) #3
Michael Lippautz
lgtm
4 years, 3 months ago (2016-08-30 12:58:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293883002/50001
4 years, 3 months ago (2016-08-30 13:20:05 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:50001)
4 years, 3 months ago (2016-08-30 13:45:24 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 13:46:20 UTC) #11
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/bcf4c66b66c0ac21e050f466ccb2b4dc90486aaf
Cr-Commit-Position: refs/heads/master@{#39016}

Powered by Google App Engine
This is Rietveld 408576698