Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2293853003:
Roll WebGL 12b543b..5888a9f (Closed)
DescriptionRoll WebGL 12b543b..5888a9f
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12b543b..5888a9f
BUG=638470
TEST=bots
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel
Committed: https://crrev.com/dd5140596eabf7e767bec277cc6c81176cf1870f
Cr-Commit-Position: refs/heads/master@{#415982}
Patch Set 1 #Patch Set 2 : update webgl2 expectations #
Total comments: 1
Patch Set 3 : retest #Patch Set 4 : update webgl 2 expectation again #
Total comments: 1
Messages
Total messages: 32 (20 generated)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
The CQ bit was unchecked by yunchao.he@intel.com
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Roll WebGL 12b543b..5888a9f https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12b543... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL 12b543b..5888a9f https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12b543... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ==========
yunchao.he@intel.com changed reviewers: + kbr@chromium.org, zmo@chromium.org
Roll in Yizhou's patch(https://github.com/KhronosGroup/WebGL/pull/1976) to test luminance and alpha color format against my previous patch about CopyTexSubImage3D on all bots. Unfortunately, there are some failures. PTAL. Thanks! I will take a look at the luminance_alpha failure for CopyTexSubImage3D.
https://codereview.chromium.org/2293853003/diff/20001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2293853003/diff/20001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:67: self.Fail('deqp/functional/gles3/negativefragmentapi.html', Did we change this test? It's surprising this is failing.
On 2016/08/31 16:02:37, Zhenyao Mo wrote: > https://codereview.chromium.org/2293853003/diff/20001/content/test/gpu/gpu_te... > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > https://codereview.chromium.org/2293853003/diff/20001/content/test/gpu/gpu_te... > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:67: > self.Fail('deqp/functional/gles3/negativefragmentapi.html', > Did we change this test? It's surprising this is failing. AFAIK, there is no update in the test. I guess that the failure is caused by Chromium/Angle.
On 2016/08/31 16:08:42, yunchao wrote: > On 2016/08/31 16:02:37, Zhenyao Mo wrote: > > > https://codereview.chromium.org/2293853003/diff/20001/content/test/gpu/gpu_te... > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > > > > https://codereview.chromium.org/2293853003/diff/20001/content/test/gpu/gpu_te... > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:67: > > self.Fail('deqp/functional/gles3/negativefragmentapi.html', > > Did we change this test? It's surprising this is failing. > > AFAIK, there is no update in the test. I guess that the failure is caused by > Chromium/Angle. That can't be. Your roll does not change Chromium/ANGLE code at all. Can you double check? It might just be a flake.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/08/31 16:29:40, Zhenyao Mo wrote: > On 2016/08/31 16:08:42, yunchao wrote: > > On 2016/08/31 16:02:37, Zhenyao Mo wrote: > > > > > > https://codereview.chromium.org/2293853003/diff/20001/content/test/gpu/gpu_te... > > > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > > > > > > > > https://codereview.chromium.org/2293853003/diff/20001/content/test/gpu/gpu_te... > > > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:67: > > > self.Fail('deqp/functional/gles3/negativefragmentapi.html', > > > Did we change this test? It's surprising this is failing. > > > > AFAIK, there is no update in the test. I guess that the failure is caused by > > Chromium/Angle. > > That can't be. Your roll does not change Chromium/ANGLE code at all. Can you > double check? It might just be a flake. I must be not conscious when I replied to you... It was mid-night at that time. Yes, you are correct, zhenyao. negativefragmentapi.html was flaky at that time I run the bots, although it failed twice. In patchset 3, I commented it. The bot was green. I have removed negativefragmentapi.html from the webgl2 conformance test expectation. please take another look. Thanks!
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Roll WebGL 12b543b..5888a9f https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12b543... BUG= TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL 12b543b..5888a9f https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12b543... BUG=638470 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ==========
The copy-texture-image-luma-format.html can be fixed by this change: https://codereview.chromium.org/2301823003/.
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/09/01 10:24:27, yunchao wrote: > The copy-texture-image-luma-format.html can be fixed by this change: > https://codereview.chromium.org/2301823003/. lgtm If a test is flaky, please mark it as flaky.
The CQ bit was checked by zmo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 12b543b..5888a9f https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12b543... BUG=638470 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL 12b543b..5888a9f https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12b543... BUG=638470 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Roll WebGL 12b543b..5888a9f https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12b543... BUG=638470 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel ========== to ========== Roll WebGL 12b543b..5888a9f https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/12b543... BUG=638470 TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel Committed: https://crrev.com/dd5140596eabf7e767bec277cc6c81176cf1870f Cr-Commit-Position: refs/heads/master@{#415982} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/dd5140596eabf7e767bec277cc6c81176cf1870f Cr-Commit-Position: refs/heads/master@{#415982}
Message was sent while issue was closed.
Kai: FYI. https://codereview.chromium.org/2293853003/diff/60001/content/test/gpu/gpu_te... File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): https://codereview.chromium.org/2293853003/diff/60001/content/test/gpu/gpu_te... content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:43: self.Fail('conformance2/misc/expando-loss-2.html', bug=483282) Kai: FYI. We'll need to remove this once your other patch lands.
Message was sent while issue was closed.
On 2016/09/01 18:00:55, Ken Russell wrote: > Kai: FYI. > > https://codereview.chromium.org/2293853003/diff/60001/content/test/gpu/gpu_te... > File content/test/gpu/gpu_tests/webgl2_conformance_expectations.py (right): > > https://codereview.chromium.org/2293853003/diff/60001/content/test/gpu/gpu_te... > content/test/gpu/gpu_tests/webgl2_conformance_expectations.py:43: > self.Fail('conformance2/misc/expando-loss-2.html', bug=483282) > Kai: FYI. We'll need to remove this once your other patch lands. copy-tex-sub-image-2d-partial-texture added here fails on Nexus 5X, 6 and 6P. |
